Files @ r25079:09d645764ffe
Branch filter:

Location: cpp/openttd-patchpack/source/cmake/CompileFlags.cmake - annotation

Patric Stout
Change: rename setting "max_heightlevel" to "map_height_limit"

This better reflects what it is, and hopefully removes a bit of
the confusion people are having what this setting actually does.

Additionally, update the text on the setting to better inform
users what it is doing exactly, so they can make an educated
decision on how to change it.

Next commit will introduce an "auto" value, which should be the
new default. The rename has as added benefit that everyone will
start out on the "auto" value.
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24342:30be07a68865
r24342:30be07a68865
r24349:3fa910f6f5ee
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24287:d246a6dccc69
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24293:0a4ec74d6552
r24293:0a4ec74d6552
r24293:0a4ec74d6552
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24304:fcbe4a05932b
r24304:fcbe4a05932b
r24304:fcbe4a05932b
r24349:3fa910f6f5ee
r24304:fcbe4a05932b
r24304:fcbe4a05932b
r24304:fcbe4a05932b
r24304:fcbe4a05932b
r24304:fcbe4a05932b
r24349:3fa910f6f5ee
r24304:fcbe4a05932b
r24304:fcbe4a05932b
r24304:fcbe4a05932b
r24304:fcbe4a05932b
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24303:287e51ec3b6d
r24303:287e51ec3b6d
r24303:287e51ec3b6d
r24303:287e51ec3b6d
r24303:287e51ec3b6d
r24349:3fa910f6f5ee
r24349:3fa910f6f5ee
r24303:287e51ec3b6d
r24349:3fa910f6f5ee
r24303:287e51ec3b6d
r24349:3fa910f6f5ee
r24349:3fa910f6f5ee
r24303:287e51ec3b6d
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24546:bdcda52f2042
r24546:bdcda52f2042
r24612:8f668fc7640a
r24612:8f668fc7640a
r24612:8f668fc7640a
r24546:bdcda52f2042
r24612:8f668fc7640a
r24612:8f668fc7640a
r24612:8f668fc7640a
r24612:8f668fc7640a
r24612:8f668fc7640a
r24612:8f668fc7640a
r24546:bdcda52f2042
r24546:bdcda52f2042
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24244:556df3f1e087
r24244:556df3f1e087
r24349:3fa910f6f5ee
r24244:556df3f1e087
# Macro which contains all bits to setup the compile flags correctly.
#
# compile_flags()
#
macro(compile_flags)
    if(MSVC)
        # Switch to MT (static) instead of MD (dynamic) binary

        # For MSVC two generators are available
        # - a command line generator (Ninja) using CMAKE_BUILD_TYPE to specify the
        #   configuration of the build tree
        # - an IDE generator (Visual Studio) using CMAKE_CONFIGURATION_TYPES to
        #   specify all configurations that will be available in the generated solution
        list(APPEND MSVC_CONFIGS "${CMAKE_BUILD_TYPE}" "${CMAKE_CONFIGURATION_TYPES}")

        # Set usage of static runtime for all configurations
        foreach(MSVC_CONFIG ${MSVC_CONFIGS})
            string(TOUPPER "CMAKE_CXX_FLAGS_${MSVC_CONFIG}" MSVC_FLAGS)
            string(REPLACE "/MD" "/MT" ${MSVC_FLAGS} "${${MSVC_FLAGS}}")
        endforeach()

        # "If /Zc:rvalueCast is specified, the compiler follows section 5.4 of the
        # C++11 standard". We need C++11 for the way we use threads.
        add_compile_options(/Zc:rvalueCast)

        if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
            # Enable multi-threaded compilation.
            add_compile_options(/MP)
        endif()
    endif()

    # Add some -D flags for Debug builds. We cannot use add_definitions(), because
    # it does not appear to support the $<> tags.
    add_compile_options(
        "$<$<CONFIG:Debug>:-D_DEBUG>"
        "$<$<NOT:$<CONFIG:Debug>>:-D_FORTIFY_SOURCE=2>" # FORTIFY_SOURCE should only be used in non-debug builds (requires -O1+)
    )
    if(MINGW)
        add_link_options(
            "$<$<NOT:$<CONFIG:Debug>>:-fstack-protector>" # Prevent undefined references when _FORTIFY_SOURCE > 0
        )
    endif()

    # Prepare a generator that checks if we are not a debug, and don't have asserts
    # on. We need this later on to set some compile options for stable releases.
    set(IS_STABLE_RELEASE "$<AND:$<NOT:$<CONFIG:Debug>>,$<NOT:$<BOOL:${OPTION_USE_ASSERTS}>>>")

    if(MSVC)
        add_compile_options(/W3)
    elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
        add_compile_options(
            -W
            -Wall
            -Wcast-qual
            -Wextra
            -Wsign-compare
            -Wundef
            -Wpointer-arith
            -Wwrite-strings
            -Wredundant-decls
            -Wformat-security
            -Wformat=2
            -Winit-self
            -Wnon-virtual-dtor

            # Often parameters are unused, which is fine.
            -Wno-unused-parameter
            # We use 'ABCD' multichar for SaveLoad chunks identifiers
            -Wno-multichar

            # Compilers complains about that we break strict-aliasing.
            #  On most places we don't see how to fix it, and it doesn't
            #  break anything. So disable strict-aliasing to make the
            #  compiler all happy.
            -fno-strict-aliasing
        )

        # When we are a stable release (Release build + USE_ASSERTS not set),
        # assertations are off, which trigger a lot of warnings. We disable
        # these warnings for these releases.
        if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
            add_compile_options(
                "$<${IS_STABLE_RELEASE}:-Wno-unused-variable>"
                "$<${IS_STABLE_RELEASE}:-Wno-unused-but-set-parameter>"
                "$<${IS_STABLE_RELEASE}:-Wno-unused-but-set-variable>"
            )
        else()
            add_compile_options(
                "$<${IS_STABLE_RELEASE}:-Wno-unused-variable>"
                "$<${IS_STABLE_RELEASE}:-Wno-unused-parameter>"
            )
        endif()

        # Ninja processes the output so the output from the compiler
        # isn't directly to a terminal; hence, the default is
        # non-coloured output. We can override this to get nicely
        # coloured output, but since that might yield odd results with
        # IDEs, we extract it to an option.
        if(OPTION_FORCE_COLORED_OUTPUT)
            if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
                add_compile_options (-fdiagnostics-color=always)
            elseif("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
                add_compile_options (-fcolor-diagnostics)
            endif()
        endif()

        if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
            include(CheckCXXCompilerFlag)
            check_cxx_compiler_flag("-flifetime-dse=1" LIFETIME_DSE_FOUND)

            add_compile_options(
                # GCC 4.2+ automatically assumes that signed overflows do
                # not occur in signed arithmetics, whereas we are not
                # sure that they will not happen. It furthermore complains
                # about its own optimized code in some places.
                "-fno-strict-overflow"

                # Prevent optimisation supposing enums are in a range specified by the standard
                # For details, see http://gcc.gnu.org/PR43680
                "-fno-tree-vrp"

                # -flifetime-dse=2 (default since GCC 6) doesn't play
                # well with our custom pool item allocator
                "$<$<BOOL:${LIFETIME_DSE_FOUND}>:-flifetime-dse=1>"
            )
        endif()

        if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
            if (NOT CMAKE_OSX_ARCHITECTURES STREQUAL "arm64")
                include(CheckCXXCompilerFlag)
                check_cxx_compiler_flag("-mno-sse4" NO_SSE4_FOUND)

                if(NO_SSE4_FOUND)
                    add_compile_options(
                        # Don't use SSE4 for general sources to increase compatibility.
                        -mno-sse4
                    )
                endif()
            endif()
        endif()
    elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
        add_compile_options(
            -Wall
            # warning #873: function ... ::operator new ... has no corresponding operator delete ...
            -wd873
            # warning #1292: unknown attribute "fallthrough"
            -wd1292
            # warning #1899: multicharacter character literal (potential portability problem)
            -wd1899
            # warning #2160: anonymous union qualifier is ignored
            -wd2160
        )
    else()
        message(FATAL_ERROR "No warning flags are set for this compiler yet; please consider creating a Pull Request to add support for this compiler.")
    endif()

    if(NOT WIN32)
        # rdynamic is used to get useful stack traces from crash reports.
        set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -rdynamic")
    endif()
endmacro()