|
Patric Stout
|
r25198:a701a159e9ab
|
3 years ago
|
|
Remove: "language" field from server/client
The original idea was that people could find a server they could talk in their native language on. This isn't really used in that way. There are several reasons for removing this:
- the client also sends his "language" to the server, but nothing is doing anything with this. - flags are a bad way to represent languages, and over the years we had several (rightfully) complaints about this. - most servers have their language set to "All", and prefix the servername with the language it is about. This is a much more efficient way to do the same.
All in all, this feature should go back to the drawing board. Maybe it could work in another form, but this form is not it.
|
|
Patric Stout
|
r25197:81f87c2b998f
|
3 years ago
|
|
Remove: "map_name" from server announcements / listing
The idea back in the days was nice, but it never resulted in anything useful. Most servers either read "(loaded game)" or "Random Map", neither being useful. It was meant for heightmaps, so you could find a server that was using a specific one .. but there are many things wrong with that idea. Mostly, servers tend to save and load savegames from time to time, after which the original heightmap used was lost.
All in all, removing map_name all together is just better.
|
|
S. D. Cloudt
|
r23917:50c2317ea357
|
5 years ago
|
|
|
|
Patric Stout
|
r23483:3733e6b8ff17
|
6 years ago
|
|
Remove: ENABLE_NETWORK switch
This switch has been a pain for years. Often disabling broke compilation, as no developer compiles OpenTTD without, neither do any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it clearly shows that the current solution was a poor one. 350+ instances of "#ifdef ENABLE_NETWORK" were in the code, of which only ~30 in the networking code itself. The rest were all around the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and make sure the rest of the code can simply assume network is available. This was also partially done, and most variables were correct if networking was disabled. Despite that, often the #ifdefs were still used.
With the recent removal of DOS, there is also no platform anymore which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No replacement is planned, but if you feel we really need this option, we welcome any Pull Request which implements this in a way that doesn't crawl through the code like this diff shows we used to.
|
|
Niels Martin Hansen
|
r23272:79ac2e685f22
|
6 years ago
|
|
|
|
rubidium
|
r13182:d311a9b54477
|
15 years ago
|
|
|
|
rubidium
|
r12768:980ae0491352
|
15 years ago
|
|
|
|
rubidium
|
r12153:8ed9495885e9
|
15 years ago
|
|
|
|
rubidium
|
r10207:a1fc2f2a33db
|
16 years ago
|
|
|
|
rubidium
|
r9451:01b0b6cc547f
|
16 years ago
|
|
(svn r13369) -Codechange: remove duplication of network configuration settings between NetworkSettings and NetworkGameInfo. -Fix: failure of changing the server password during games because the password wasn't duplicated properly.
|
|
rubidium
|
r8140:9424f012f6a2
|
17 years ago
|
|
|
|
rubidium
|
r6248:b940b09d7ab8
|
18 years ago
|
|
|
|
celestar
|
r6121:a8ff6abe7fb2
|
18 years ago
|
|
|
|
rubidium
|
r5799:f32c3dedc4ef
|
18 years ago
|
|
(svn r8361) -Codechange: make sure the range of the dates coming from the network are valid in OpenTTD -Codechange: use_password is a boolean variable -Codechange: move range checking for server_lang and map_set to Recv_NetworkGameInfo
|
|
rubidium
|
r5527:e9d8b06d490d
|
18 years ago
|
|
|
|
rubidium
|
r5475:3f5cd13d1b63
|
18 years ago
|
|
(svn r7759) -Merge: makefile rewrite. This merge features: - A proper ./configure, so everything needs to be configured only once, not for every make. - Usage of makedepend when available. This greatly reduces the time needed for generating the dependencies. - A generator for all project files. There is a single file with sources, which is used to generate Makefiles and the project files for MSVC. - Proper support for OSX universal binaries. - Object files for non-MSVC compiles are also placed in separate directories, making is faster to switch between debug and release compiles and it does not touch the directory with the source files. - Functionality to make a bundle of all needed files for for example a nightly or distribution of a binary with all needed GRFs and language files.
Note: as this merge moves almost all files, it is recommended to make a backup of your working copy before updating your working copy.
|