Codechange: Make all NWidgetPart arrays constexpr.

This ensures that the arrays are not created at runtime and prevents using non-constexpr values.

Codechange: Replace mishmash of types for widget index with WidgetID.

Indices were stored as int, but often passed around as uint/uint8_t and casts.

Now they should all use WidgetID.

Codechange: Add __FILE__/__LINE__ of WindowDesc to WindowDesc.

This is to allow unit-tests to produce more useful output.

Add: data parameter in Window::Close method.

This allows passing data when closing a window, e.g. to indicate how it was closed.

Codechange: Use begin/end of nwidget parts of begin/length.

This simplifies processing nwidget parts as, unlike the remaining length, the pointer to the end of the list never changes. This is the same principle as we use(d) for tracking end instead of length for C-style strings.

And this removes 160~ instances of the lengthof() macro.

Codechange: automatic adding of _t to (u)int types, and WChar to char32_t

for i in `find src -type f|grep -v 3rdparty/fmt|grep -v 3rdparty/catch2|grep -v 3rdparty/opengl|grep -v stdafx.h`; do sed 's/uint16& /uint16 \&/g;s/int8\([ >*),;[]\)/int8_t\1/g;s/int16\([ >*),;[]\)/int16_t\1/g;s/int32\([ >*),;[]\)/int32_t\1/g;s/int64\([ >*),;[]\)/int64_t\1/g;s/ uint32(/ uint32_t(/g;s/_uint8_t/_uint8/;s/Uint8_t/Uint8/;s/ft_int64_t/ft_int64/g;s/uint64$/uint64_t/;s/WChar/char32_t/g;s/char32_t char32_t/char32_t WChar/' -i $i; done

Codechange: migrate all Window-related timers to the new framework

This means we also say goodbye to GUITimers.

Codechange: introduce GetMainWindow() to properly account for nullptr checks

Some nullptr checks have been removed as they were not triggered with nullptr
with the null video driver and in dedicated server mode.

Fix: Crash if error message window is too wide for screen. (#10172)

This doesn't seem new, just easier to trigger with new scaling.

Change: Use Rect helpers for widget drawing.

This replaces repetitive and sometimes unwieldy use of constants.

Change: Move error window padding to widget level.

This simplifies calculation during drawing.

Change: unify the style of console error messages and convert to fmt

Always start with a capital, do not add "ERROR: " in front of it.

Fix: errors during bootstrap could still show up after bootstrap

For example, if you have a config that defines OpenGFX as baseset
but for some reason you have no basesets anymore. In that case
bootstrap downloads OpenGFX for you, but it will still show the
error that "OpenGFX was not found" after the bootstrap. This was
an error generated before the bootstrapped kicked in.

Simply muting all errors during bootstrap solves this; as we cannot
show them anyway, this is fine. Any errors that remain after
bootstrap will be generated again anyway.

Codechange: Spell 'Viewport' consistently

Some places in the codebase misspell 'Viewport' as 'ViewPort' or 'view_port'.
This patch makes everything consistent.

Fix: Out of bounds tile access in ErrmsgWindow::OnInitialPosition

This fixes part A of #7619, but not part B.

Vehicle::x_pos and Vehicle::y_pos are not required to be within the map bounds.

See also: GetTileHeightBelowAircraft()

Fix 71a3e8346: strings need to be copied too.

If it's not, iterating on it in a loop is quite pointless.