# HG changeset patch
# User Patric Stout <truebrain@openttd.org>
# Date 2020-12-25 13:44:28
# Node ID 0c8c1b28cae4c2ed3faae06c7e66ba5243a2f04c
# Parent  229f420bb209991ae7be773a2728d4737517428c

Codechange: move block a bit lower to increase readability

It was rather confusing that "library_name" was calculated, and
then not used to do the FindLibrary() call. Flipping those two
blocks around makes it a bit more sane to read.

diff --git a/src/script/api/script_controller.cpp b/src/script/api/script_controller.cpp
--- a/src/script/api/script_controller.cpp
+++ b/src/script/api/script_controller.cpp
@@ -111,11 +111,6 @@ ScriptController::~ScriptController()
 	Squirrel *engine = ScriptObject::GetActiveInstance()->engine;
 	HSQUIRRELVM vm = engine->GetVM();
 
-	/* Internally we store libraries as 'library.version' */
-	char library_name[1024];
-	seprintf(library_name, lastof(library_name), "%s.%d", library, version);
-	strtolower(library_name);
-
 	ScriptInfo *lib = ScriptObject::GetActiveInstance()->FindLibrary(library, version);
 	if (lib == nullptr) {
 		char error[1024];
@@ -123,6 +118,11 @@ ScriptController::~ScriptController()
 		throw sq_throwerror(vm, error);
 	}
 
+	/* Internally we store libraries as 'library.version' */
+	char library_name[1024];
+	seprintf(library_name, lastof(library_name), "%s.%d", library, version);
+	strtolower(library_name);
+
 	/* Get the current table/class we belong to */
 	HSQOBJECT parent;
 	sq_getstackobj(vm, 1, &parent);