# HG changeset patch # User peter1138 # Date 2007-01-14 18:38:40 # Node ID 248b3a88d9bf2fed1167a8a6e651a9bfb654c930 # Parent f82ff099edea650bdb02f494500b047f41d3c41c (svn r8120) -Fix (r8055): Station cargo waiting value clamp should be signed not unsigned. This resulted in cargo magically appearing... diff --git a/src/station_cmd.cpp b/src/station_cmd.cpp --- a/src/station_cmd.cpp +++ b/src/station_cmd.cpp @@ -2524,8 +2524,8 @@ static void UpdateStationRating(Station // if rating is <= 127 and there are any items waiting, maybe remove some goods. if (rating <= 127 && waiting != 0) { uint32 r = Random(); - if ( (uint)rating <= (r & 0x7F) ) { - waiting = max(waiting - ((r >> 8)&3) - 1, 0U); + if (rating <= (int)GB(r, 0, 7)) { + waiting = max(waiting - (int)GB(r, 8, 2) - 1, 0); waiting_changed = true; } }