# HG changeset patch
# User Patric Stout <truebrain@openttd.org>
# Date 2021-07-01 18:06:04
# Node ID 2c5cea3968c58b62ae398a15c9e82e5de169aeff
# Parent  4cf7ede03a9ffd14b41d8a37630e3879a108d04f

Codechange: simplify SaveVersionInConfig()

Clearly someone really wanted to generalize the function, but
in reality it makes it a lot longer than needed. Let's keep it
simple.

diff --git a/src/settings.cpp b/src/settings.cpp
--- a/src/settings.cpp
+++ b/src/settings.cpp
@@ -1524,18 +1524,8 @@ static void GameSaveConfig(IniFile &ini,
 static void SaveVersionInConfig(IniFile &ini)
 {
 	IniGroup *group = ini.GetGroup("version");
-
-	char version[9];
-	seprintf(version, lastof(version), "%08X", _openttd_newgrf_version);
-
-	const char * const versions[][2] = {
-		{ "version_string", _openttd_revision },
-		{ "version_number", version }
-	};
-
-	for (uint i = 0; i < lengthof(versions); i++) {
-		group->GetItem(versions[i][0], true)->SetValue(versions[i][1]);
-	}
+	group->GetItem("version_string", true)->SetValue(_openttd_revision);
+	group->GetItem("version_number", true)->SetValue(fmt::format("{:08X}", _openttd_newgrf_version));
 }
 
 /* Save a GRF configuration to the given group name */