# HG changeset patch # User truelight # Date 2007-07-13 19:06:12 # Node ID 4216e7899b68f7e126fa20658e6081035305421d # Parent 0e9f3848c4e85fa8388ce51e67ff7a98c13d9d3a (svn r10552) -Fix [FS#1034, r10546]: opening Available Aircrafts segfaulted diff --git a/src/build_vehicle_gui.cpp b/src/build_vehicle_gui.cpp --- a/src/build_vehicle_gui.cpp +++ b/src/build_vehicle_gui.cpp @@ -672,7 +672,7 @@ static void GenerateBuildTrainList(Windo int num_wagons = 0; buildvehicle_d *bv = &WP(w, buildvehicle_d); - bv->filter.railtype = (w->window_number == 0) ? RAILTYPE_END : GetRailType(w->window_number); + bv->filter.railtype = (w->window_number <= VEH_END) ? RAILTYPE_END : GetRailType(w->window_number); EngList_RemoveAll(&bv->eng_list); @@ -764,7 +764,8 @@ static void GenerateBuildAircraftList(Wi sel_id = INVALID_ENGINE; for (eid = AIRCRAFT_ENGINES_INDEX; eid < AIRCRAFT_ENGINES_INDEX + NUM_AIRCRAFT_ENGINES; eid++) { if (!IsEngineBuildable(eid, VEH_AIRCRAFT, _local_player)) continue; - if (w->window_number != 0 && !IsAircraftBuildableAtStation(eid, w->window_number)) continue; + /* First VEH_END window_numbers are fake to allow a window open for all different types at once */ + if (w->window_number > VEH_END && !IsAircraftBuildableAtStation(eid, w->window_number)) continue; EngList_Add(&bv->eng_list, eid); if (eid == bv->sel_engine) sel_id = eid; @@ -887,7 +888,7 @@ static void DrawBuildVehicleWindow(Windo const buildvehicle_d *bv = &WP(w, buildvehicle_d); uint max = min(w->vscroll.pos + w->vscroll.cap, EngList_Count(&bv->eng_list)); - SetWindowWidgetDisabledState(w, BUILD_VEHICLE_WIDGET_BUILD, w->window_number == 0); + SetWindowWidgetDisabledState(w, BUILD_VEHICLE_WIDGET_BUILD, w->window_number <= VEH_END); SetVScrollCount(w, EngList_Count(&bv->eng_list)); SetDParam(0, bv->filter.railtype + STR_881C_NEW_RAIL_VEHICLES); // This should only affect rail vehicles