# HG changeset patch
# User rubidium <rubidium@openttd.org>
# Date 2007-02-14 09:34:12
# Node ID 4e2beebaf215ee4a6c6884f08e48cd4846f38b42
# Parent  02364980b4077cdb7647a4014226b1983c4da487

(svn r8726) -Codechange: bools are 1 or 0 according to the C++ standard and refactor RoadStop::AllocateBay to remove a loop condition. Suggestions by Tron.

diff --git a/src/roadveh_cmd.cpp b/src/roadveh_cmd.cpp
--- a/src/roadveh_cmd.cpp
+++ b/src/roadveh_cmd.cpp
@@ -519,7 +519,7 @@ static void ClearCrashedStation(Vehicle 
 	rs->SetEntranceBusy(false);
 
 	/* Free the parking bay */
-	rs->FreeBay(HASBIT(v->u.road.state, RVS_USING_SECOND_BAY) ? 1 : 0);
+	rs->FreeBay(HASBIT(v->u.road.state, RVS_USING_SECOND_BAY));
 }
 
 static void RoadVehDelete(Vehicle *v)
@@ -1437,7 +1437,7 @@ again:
 				RoadStop *rs = GetRoadStopByTile(v->tile, GetRoadStopType(v->tile));
 
 				/* Vehicle is leaving a road stop tile, mark bay as free and clear the usage bit */
-				rs->FreeBay(HASBIT(v->u.road.state, RVS_USING_SECOND_BAY) ? 1 : 0);
+				rs->FreeBay(HASBIT(v->u.road.state, RVS_USING_SECOND_BAY));
 				rs->SetEntranceBusy(false);
 			}
 		}
diff --git a/src/station.cpp b/src/station.cpp
--- a/src/station.cpp
+++ b/src/station.cpp
@@ -509,17 +509,14 @@ bool RoadStop::HasFreeBay() const
  */
 uint RoadStop::AllocateBay()
 {
+	assert(HasFreeBay());
+
 	/* Find the first free bay. If the bit is set, the bay is free. */
-	for (uint bay_nr = 0; bay_nr < MAX_BAY_COUNT; bay_nr++) {
-		if (HASBIT(status, bay_nr)) {
-			CLRBIT(status, bay_nr);
-			return bay_nr;
-		}
-	}
+	uint bay_nr = 0;
+	while (!HASBIT(status, bay_nr)) bay_nr++;
 
-	/* There has to be a free bay (precondition) */
-	NOT_REACHED();
-	return 0;
+	CLRBIT(status, bay_nr);
+	return bay_nr;
 }
 
 /**
@@ -542,5 +539,5 @@ bool RoadStop::IsEntranceBusy() const
 /** Makes an entrance occupied or free */
 void RoadStop::SetEntranceBusy(bool busy)
 {
-	SB(status, 7, 1, !!busy);
+	SB(status, 7, 1, busy);
 }