# HG changeset patch # User smatz # Date 2009-06-09 23:34:48 # Node ID 651317b20e1eff1f919461ca313086ba202ba6a8 # Parent 075a700b8d450b261df4199708f2e9c02e3c97c7 (svn r16547) -Codechange: make CircularTileSearch a tiny bit faster diff --git a/src/map.cpp b/src/map.cpp --- a/src/map.cpp +++ b/src/map.cpp @@ -307,12 +307,17 @@ bool CircularTileSearch(TileIndex *tile, uint extent[DIAGDIR_END] = { w, h, w, h }; for (uint n = 0; n < radius; n++) { - for (DiagDirection dir = DIAGDIR_NE; dir < DIAGDIR_END; dir++) { + for (DiagDirection dir = DIAGDIR_BEGIN; dir < DIAGDIR_END; dir++) { + /* Is the tile within the map? */ for (uint j = extent[dir] + n * 2 + 1; j != 0; j--) { - if (x <= MapMaxX() && y <= MapMaxY() && ///< Is the tile within the map? - proc(TileXY(x, y), user_data)) { ///< Is the callback successful? - *tile = TileXY(x, y); - return true; ///< then stop the search + if (x < MapSizeX() && y < MapSizeY()) { + TileIndex t = TileXY(x, y); + /* Is the callback successful? */ + if (proc(t, user_data)) { + /* Stop the search */ + *tile = t; + return true; + } } /* Step to the next 'neighbour' in the circular line */