# HG changeset patch
# User Patric Stout <truebrain@openttd.org>
# Date 2021-01-31 09:36:07
# Node ID c35921991883820613af8aabbdd38be8f9830813
# Parent  ddd436699aee29f398578f82c626187b7485e8fe

Fix 2db88953: default Network Server List sorter put compatible servers in wrong order (#8626)

If a server is compatible, it falls back to sorting by clients.
This used to be in reverse, so full servers are on top. With
the codechange commit, this was removed by accident, and as
such empty servers were on top. This is silly.

diff --git a/src/network/network_gui.cpp b/src/network/network_gui.cpp
--- a/src/network/network_gui.cpp
+++ b/src/network/network_gui.cpp
@@ -330,10 +330,9 @@ protected:
 		if (r == 0) r = b->info.compatible - a->info.compatible;
 		/* Passworded servers should be below unpassworded servers */
 		if (r == 0) r = a->info.use_password - b->info.use_password;
-		/* Finally sort on the number of clients of the server */
-		if (r == 0) return NGameClientSorter(a, b);
 
-		return r < 0;
+		/* Finally sort on the number of clients of the server in reverse order. */
+		return (r != 0) ? r < 0: !NGameClientSorter(a, b);
 	}
 
 	/** Sort the server list */