# HG changeset patch # User yexo # Date 2009-02-24 19:15:23 # Node ID df820ada71fcca202991c5f4df726045d8619284 # Parent e54230975939f2c740d35de403949c9d88c351de (svn r15567) -Fix [FS#2674]: When building signals by dragging from a pre/entry/combo block signal, the signal you started at became a normal block signal. diff --git a/src/rail_cmd.cpp b/src/rail_cmd.cpp --- a/src/rail_cmd.cpp +++ b/src/rail_cmd.cpp @@ -807,6 +807,7 @@ CommandCost CmdBuildTrainDepot(TileIndex * - p1 = (bit 9-11)- start cycle from this signal type * - p1 = (bit 12-14)-wrap around after this signal type * - p1 = (bit 15-16)-cycle the signal direction this many times + * - p1 = (bit 17) - 1 = don't modify an existing signal but don't fail either, 0 = always set new signal type * @param p2 used for CmdBuildManySignals() to copy direction of first signal * TODO: p2 should be replaced by two bits for "along" and "against" the track. */ @@ -845,6 +846,9 @@ CommandCost CmdBuildSingleSignal(TileInd } } + /* In case we don't want to change an existing signal, return without error. */ + if (HasBit(p1, 17) && HasSignalOnTrack(tile, track)) return CommandCost(); + /* you can not convert a signal if no signal is on track */ if (convert_signal && !HasSignalOnTrack(tile, track)) return CMD_ERROR; @@ -1095,6 +1099,7 @@ static CommandCost CmdSignalTrackHelper( SB(p1, 3, 1, mode); SB(p1, 4, 1, semaphores); SB(p1, 5, 3, sigtype); + if (!remove && signal_ctr == 0) SetBit(p1, 17); /* Pick the correct orientation for the track direction */ signals = 0;