# HG changeset patch
# User Patric Stout <truebrain@openttd.org>
# Date 2020-12-08 22:11:47
# Node ID f178a9589b1f372e07cab5a2d61837da84a8d872
# Parent  db10f80aa82860503bde9901d783ebc3c7ddec6f

Codechange: to create or not to create a folder, that is the question

This was just weird. With XDG _personal_dir was created already,
but later on it was checked if it was different from config_dir,
and the creation was skipped. All this checking and validation
makes my head spin .. let's make it a bit more simple.

diff --git a/src/fileio.cpp b/src/fileio.cpp
--- a/src/fileio.cpp
+++ b/src/fileio.cpp
@@ -1234,7 +1234,6 @@ void DeterminePaths(const char *exe)
 		/* We are using the XDG configuration home for the config file,
 		 * then store the rest in the XDG data home folder. */
 		_personal_dir = _searchpaths[SP_PERSONAL_DIR_XDG];
-		FioCreateDirectory(_personal_dir);
 	} else
 #endif
 	{
@@ -1242,9 +1241,9 @@ void DeterminePaths(const char *exe)
 	}
 
 	/* Make the necessary folders */
+	FioCreateDirectory(config_dir);
 #if defined(WITH_PERSONAL_DIR)
-	FioCreateDirectory(config_dir);
-	if (config_dir != _personal_dir) FioCreateDirectory(_personal_dir);
+	FioCreateDirectory(_personal_dir);
 #endif
 
 	DEBUG(misc, 3, "%s found as personal directory", _personal_dir);