cpp/openttd-patchpack/source Changeset - r28773:0150d0acc334

Changeset - r28773:0150d0acc334

Parent rev.

Child rev.

[Not reviewed]

master

0 6 0

Rubidium - 10 months ago 2024-02-08 20:42:34
rubidium@openttd.org

Change: Remove saving of digit group and decimal separator configurations from the savegame

6 files changed with 13 insertions and 36 deletions:

src/saveload/compat/settings_sl_compat.h

src/settings_type.h

src/strings.cpp

src/table/settings/gui_settings.ini

src/table/settings/locale_settings.ini

src/table/settings/old_gameopt_settings.ini

0 comments (0 inline, 0 general)

src/saveload/compat/settings_sl_compat.h

➞

Show inline comments

@@ @@ -255,12 +255,12 @@ const SaveLoadCompat _settings_sl_compat @@
 	SLC_VAR("locale.units_velocity"),
 	SLC_VAR("locale.units_power"),
 	SLC_VAR("locale.units_weight"),
 	SLC_VAR("locale.units_volume"),
 	SLC_VAR("locale.units_force"),
 	SLC_VAR("locale.units_height"),
 	SLC_VAR("locale.digit_group_separator"),
 	SLC_VAR("locale.digit_group_separator_currency"),
 	SLC_VAR("locale.digit_decimal_separator"),
 	SLC_NULL_STR(1, SLV_118, SLV_TABLE_CHUNKS),
 	SLC_NULL_STR(1, SLV_118, SLV_TABLE_CHUNKS),
 	SLC_NULL_STR(1, SLV_126, SLV_TABLE_CHUNKS),
 };
 #endif /* SAVELOAD_COMPAT_SETTINGS_H */

src/settings_type.h

➞

Show inline comments

@@ @@ -219,12 +219,14 @@ struct GUISettings { @@
 	uint8_t  settings_restriction_mode;        ///< selected restriction mode in adv. settings GUI. @see RestrictionMode
 	bool   newgrf_show_old_versions;         ///< whether to show old versions in the NewGRF list
 	uint8_t  newgrf_default_palette;           ///< default palette to use for NewGRFs without action 14 palette information
 	bool   scale_bevels;                     ///< bevels are scaled with GUI scale.
 	std::string digit_decimal_separator; ///< decimal separator
 	/**
 	 * Returns true when the user has sufficient privileges to edit newgrfs on a running game
 	 * @return whether the user has sufficient privileges to edit newgrfs in an existing game
 	 */
 	bool UserIsAllowedToChangeNewGRFs() const
+	{
@@ @@ -262,15 +264,12 @@ struct LocaleSettings { @@
 	byte        units_velocity_nautical;          ///< unit system for velocity of ships and aircraft
 	byte        units_power;                      ///< unit system for power
 	byte        units_weight;                     ///< unit system for weight
 	byte        units_volume;                     ///< unit system for volume
 	byte        units_force;                      ///< unit system for force
 	byte        units_height;                     ///< unit system for height
 	std::string digit_group_separator;            ///< thousand separator for non-currencies
 	std::string digit_group_separator_currency;   ///< thousand separator for currencies
 	std::string digit_decimal_separator;          ///< decimal separator
 };
 /** Settings related to news */
 struct NewsSettings {
 	uint8_t arrival_player;                                 ///< NewsDisplay of vehicles arriving at new stations of current player
 	uint8_t arrival_other;                                  ///< NewsDisplay of vehicles arriving at new stations of other players

src/strings.cpp

➞

Show inline comments

@@ @@ -379,13 +379,13 @@ void SetDParamStr(size_t n, std::string @@
+{
 	_global_string_params.SetParam(n, std::move(str));
+}
 static const char *GetDecimalSeparator()
+{
-	const char *decimal_separator = _settings_game.locale.digit_decimal_separator.c_str();
+	const char *decimal_separator = _settings_client.gui.digit_decimal_separator.c_str();
 	if (StrEmpty(decimal_separator)) decimal_separator = _langpack.langpack->digit_decimal_separator;
 	return decimal_separator;
+}
 void InitializeNumberFormats()
+{

src/table/settings/gui_settings.ini

➞

Show inline comments

@@ @@ -25,12 +25,13 @@ static const SettingVariant _gui_setting @@
 [post-amble]
 };
 [templates]
 SDTC_BOOL  =  SDTC_BOOL(              $var,        $flags, $def,                              $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to,        $cat, $extra, $startup),
 SDTC_OMANY = SDTC_OMANY(              $var, $type, $flags, $def,             $max, $full,     $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to,        $cat, $extra, $startup),
 SDTC_VAR   =   SDTC_VAR(              $var, $type, $flags, $def,       $min, $max, $interval, $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to,        $cat, $extra, $startup),
 SDTC_SSTR  =  SDTC_SSTR(              $var, $type, $flags, $def,             0,                                        $pre_cb, $post_cb,                             $from, $to,        $cat, $extra, $startup),
 [validation]
 SDTC_OMANY = static_assert($max <= MAX_$type, "Maximum value for $var exceeds storage size");
 SDTC_VAR = static_assert($max <= MAX_$type, "Maximum value for $var exceeds storage size");
 [defaults]
@@ @@ -900,6 +901,12 @@ var = gui.scale_bevels @@
 flags    = SF_NOT_IN_SAVE | SF_NO_NETWORK_SYNC
 def      = true
 post_cb  = [](auto) { SetupWidgetDimensions(); ReInitAllWindows(true); }
 cat      = SC_BASIC
 startup  = true
 [SDTC_SSTR]
 var      = gui.digit_decimal_separator
 flags    = SF_NOT_IN_SAVE | SF_NO_NETWORK_SYNC
 type     = SLE_STRQ
 def      = nullptr
 post_cb  = [](auto) { MarkWholeScreenDirty(); }

src/table/settings/locale_settings.ini

➞

Show inline comments

@@ @@ -20,13 +20,12 @@ static_assert(_locale_currencies.size() @@
 static const SettingVariant _locale_settings_table[] = {
 [post-amble]
 };
 [templates]
 SDTG_OMANY = SDTG_OMANY($name,              $type, $flags, $var, $def,       $max, $full,     $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to,        $cat, $extra, $startup),
 SDT_OMANY  =  SDT_OMANY(GameSettings, $var, $type, $flags, $def,             $max, $full,     $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to, $load, $cat, $extra, $startup),
 SDT_SSTR   =   SDT_SSTR(GameSettings, $var, $type, $flags, $def,                                                       $pre_cb, $post_cb, $from, $to,        $cat, $extra, $startup),
 [validation]
 SDTG_OMANY = static_assert($max <= MAX_$type, "Maximum value for $var exceeds storage size");
 SDT_OMANY = static_assert($max <= MAX_$type, "Maximum value for GameSettings.$var exceeds storage size");
 [defaults]
@@ @@ -166,33 +165,6 @@ max = 2 @@
 full     = _locale_units
 post_cb  = [](auto) { MarkWholeScreenDirty(); }
 cat      = SC_BASIC
 str      = STR_CONFIG_SETTING_LOCALISATION_UNITS_HEIGHT
 strhelp  = STR_CONFIG_SETTING_LOCALISATION_UNITS_HEIGHT_HELPTEXT
 strval   = STR_CONFIG_SETTING_LOCALISATION_UNITS_HEIGHT_IMPERIAL
 [SDT_SSTR]
 var      = locale.digit_group_separator
 type     = SLE_STRQ
 from     = SLV_118
 flags    = SF_NO_NETWORK_SYNC
 def      = nullptr
 post_cb  = [](auto) { MarkWholeScreenDirty(); }
 cat      = SC_BASIC
 [SDT_SSTR]
 var      = locale.digit_group_separator_currency
 type     = SLE_STRQ
 from     = SLV_118
 flags    = SF_NO_NETWORK_SYNC
 def      = nullptr
 post_cb  = [](auto) { MarkWholeScreenDirty(); }
 cat      = SC_BASIC
 [SDT_SSTR]
 var      = locale.digit_decimal_separator
 type     = SLE_STRQ
 from     = SLV_126
 flags    = SF_NO_NETWORK_SYNC
 def      = nullptr
 post_cb  = [](auto) { MarkWholeScreenDirty(); }
 cat      = SC_BASIC

src/table/settings/old_gameopt_settings.ini

➞

Show inline comments

@@ @@ -29,13 +29,12 @@ static const SettingVariant _old_gameopt @@
  * for savegames version 0 - though it is an array, it has to go through the byteswap process */
 [post-amble]
 };
 [templates]
 SDTG_LIST    =  SDTG_LIST($name,              $type, $flags, $var, $def, $length, $from, $to, $cat, $extra, $startup),
 SDTG_VAR     =   SDTG_VAR($name,              $type, $flags, $var, $def, $min, $max, $interval,  $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to, $cat, $extra, $startup),
 SDT_NULL     =   SDT_NULL(                                                          $length,                                                            $from, $to),
 SDTC_OMANY   = SDTC_OMANY(              $var, $type, $flags, $def,       $max, $full,            $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to,        $cat, $extra, $startup),
 SDTG_OMANY   = SDTG_OMANY($name,              $type, $flags, $var, $def, $max, $full,            $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to,        $cat, $extra, $startup),
 SDT_OMANY    =  SDT_OMANY(GameSettings, $var, $type, $flags, $def,       $max, $full,            $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to, $load, $cat, $extra, $startup),
 SDT_VAR      =    SDT_VAR(GameSettings, $var, $type, $flags, $def, $min, $max,        $interval, $str, $strhelp, $strval, $pre_cb, $post_cb, $str_cb, $help_cb, $val_cb, $from, $to,        $cat, $extra, $startup),
 [validation]

0 comments (0 inline, 0 general)