cpp/openttd-patchpack/source Changeset - r1877:0c39eb68bf5c

Changeset - r1877:0c39eb68bf5c

Parent rev.

Child rev.

[Not reviewed]

master

0 3 0

Darkvater - 19 years ago 2005-05-30 14:45:36
darkvater@openttd.org

(svn r2383) - Fix: Monkey-testing turned up some command crashes.

3 files changed with 8 insertions and 3 deletions:

aircraft_cmd.c

command.c

misc_cmd.c

0 comments (0 inline, 0 general)

aircraft_cmd.c

➞

Show inline comments

@@ @@ -170,7 +170,7 @@ int32 CmdBuildAircraft(int x, int y, uin @@
 	Vehicle *vl[3], *v, *u, *w;
 	UnitID unit_num;
 	TileIndex tile = TILE_FROM_XY(x,y);
-	const AircraftVehicleInfo *avi = AircraftVehInfo(p1);
 	const AircraftVehicleInfo *avi;
 	Engine *e;
 	if (!IsEngineBuildable(p1, VEH_Aircraft)) return CMD_ERROR;
@@ @@ -186,6 +186,7 @@ int32 CmdBuildAircraft(int x, int y, uin @@
 	if (flags & DC_QUERY_COST) return value;
 	avi = AircraftVehInfo(p1);
 	// allocate 2 or 3 vehicle structs, depending on type
 	if (!AllocateVehicles(vl, (avi->subtype & 1) == 0 ? 3 : 2) ||
 				IsOrderPoolFull())

command.c

➞

Show inline comments

@@ @@ -428,6 +428,10 @@ bool DoCommandP(TileIndex tile, uint32 p @@
 	// get pointer to command handler
 	assert((cmd & 0xFF) < lengthof(_command_proc_table));
 	proc = _command_proc_table[cmd & 0xFF].proc;
 	if (proc == NULL) {
 		_cmd_text = NULL;
 		return false;
+	}
 	// Some commands have a different output in dryrun than the realrun
 	//  e.g.: if you demolish a whole town, the dryrun would say okay.

misc_cmd.c

➞

Show inline comments

@@ @@ -256,7 +256,7 @@ int32 CmdGiveMoney(int x, int y, uint32 @@
  */
 int32 CmdChangeDifficultyLevel(int x, int y, uint32 flags, uint32 p1, uint32 p2)
+{
-	if ((int32)p1 >= GAME_DIFFICULTY_NUM && p1 != (uint32)-1L) return CMD_ERROR;
+	if (p1 != (uint32)-1L && ((int32)p1 >= GAME_DIFFICULTY_NUM || (int32)p1 < 0)) return CMD_ERROR;
 	if (flags & DC_EXEC) {
 		if (p1 != (uint32)-1L) {
@@ @@ -267,7 +267,7 @@ int32 CmdChangeDifficultyLevel(int x, in @@
 		/* If we are a network-client, update the difficult setting (if it is open).
 		 * Use this instead of just dirtying the window because we need to load in
 		* the new difficulty settings */
+		 * the new difficulty settings */
 		if (_networking && !_network_server && FindWindowById(WC_GAME_OPTIONS, 0) != NULL)
 			ShowGameDifficulty();
+	}

0 comments (0 inline, 0 general)