cpp/openttd-patchpack/source Changeset - r25297:2a1124f12100

Changeset - r25297:2a1124f12100

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

Patric Stout - 3 years ago 2021-04-28 21:09:03
truebrain@openttd.org

Fix b3003dd1: swap SERVER_GAME_INFO with CLIENT_GAME_INFO (#9129)

The idea is that if you query an older server that does not support
this packet yet, the client receives an error. The assumption was
that on every "illegal packet" the connection would be closed. This
turns out to be false.

Now CLIENT_GAME_INFO aligns with the old PACKET_CLIENT_NEWGRFS_CHECKED,
which does a pre-check (which fails), and an error is sent back
and the connection is closed.

This is not a nice solution, but it is the best we got.

1 file changed with 1 insertions and 1 deletions:

src/network/core/tcp_game.h

0 comments (0 inline, 0 general)

src/network/core/tcp_game.h

➞

Show inline comments

@@ @@ -43,8 +43,8 @@ enum PacketGameType { @@
 	PACKET_SERVER_COMPANY_INFO,          ///< Information about a single company.
 	/* Packets used to get the game info. */
 	PACKET_SERVER_GAME_INFO,             ///< Information about the server.
 	PACKET_CLIENT_GAME_INFO,             ///< Request information about the server.
 	PACKET_SERVER_GAME_INFO,             ///< Information about the server.
 	/*
 	 * Packets after here assume that the client

0 comments (0 inline, 0 general)