cpp/openttd-patchpack/source Changeset - r27951:3c97347b5d76

Changeset - r27951:3c97347b5d76

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

PeterN - 12 months ago 2023-09-20 07:56:53
peter1138@openttd.org

Codechange: Don't pass GUI cargo filter constants to command system. (#11320)

CMD_BUILD_VEHICLE expects CT_INVALID to indicate a new vehicle should not
be refitted on build, but the code passed CF_NONE instead. CF_NONE has the
same numeric value at CT_INVALID, so the test passed, but...

1 file changed with 2 insertions and 2 deletions:

src/build_vehicle_gui.cpp

0 comments (0 inline, 0 general)

src/build_vehicle_gui.cpp

➞

Show inline comments

@@ @@ -1323,7 +1323,7 @@ struct BuildVehicleWindow : Window { @@
 	void SelectEngine(EngineID engine)
+	{
 		CargoID cargo = this->cargo_filter[this->cargo_filter_criteria];
-		if (cargo == CF_ANY) cargo = CF_NONE;
+		if (cargo == CF_ANY || cargo == CF_ENGINES || cargo == CF_NONE) cargo = CT_INVALID;
 		this->sel_engine = engine;
 		this->SetBuyVehicleText();
@@ @@ -1647,7 +1647,7 @@ struct BuildVehicleWindow : Window { @@
 				EngineID sel_eng = this->sel_engine;
 				if (sel_eng != INVALID_ENGINE) {
 					CargoID cargo = this->cargo_filter[this->cargo_filter_criteria];
-					if (cargo == CF_ANY || cargo == CF_ENGINES) cargo = CF_NONE;
+					if (cargo == CF_ANY || cargo == CF_ENGINES || cargo == CF_NONE) cargo = CT_INVALID;
 					if (this->vehicle_type == VEH_TRAIN && RailVehInfo(sel_eng)->railveh_type == RAILVEH_WAGON) {
 						Command<CMD_BUILD_VEHICLE>::Post(GetCmdBuildVehMsg(this->vehicle_type), CcBuildWagon, this->window_number, sel_eng, true, cargo, INVALID_CLIENT_ID);
 					} else {

0 comments (0 inline, 0 general)