cpp/openttd-patchpack/source Changeset - r24505:60fa3a7db922

Changeset - r24505:60fa3a7db922

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

Patric Stout - 3 years ago 2020-12-26 12:48:57
truebrain@openttd.org

Fix: [Actions] cmakeBuildType is only used with CMakeListsTxtBasic (#8435)

We use CMakeListsTxtAdvanced, and as such, we have to do this our
self via "-DCMAKE_BUILD_TYPE=RelWithDebInfo". Otherwise we are
producing Debug builds instead of Release builds. Oops.

1 file changed with 3 insertions and 6 deletions:

.github/workflows/release.yml

0 comments (0 inline, 0 general)

.github/workflows/release.yml

➞

Show inline comments

@@ @@ -479,8 +479,7 @@ jobs: @@
         useVcpkgToolchainFile: false
         buildDirectory: '${{ github.workspace }}/build-host'
         buildWithCMakeArgs: '--target tools'
         cmakeBuildType: RelWithDebInfo
         cmakeAppendedArgs: ' -GNinja -DOPTION_TOOLS_ONLY=ON'
         cmakeAppendedArgs: ' -GNinja -DOPTION_TOOLS_ONLY=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo'
     - name: Install MSVC problem matcher
       uses: ammaraskar/msvc-problem-matcher@master
@@ @@ -492,8 +491,7 @@ jobs: @@
         cmakeListsOrSettingsJson: CMakeListsTxtAdvanced
         useVcpkgToolchainFile: true
         buildDirectory: '${{ github.workspace }}/build'
         cmakeBuildType: RelWithDebInfo
         cmakeAppendedArgs: ' -GNinja -DOPTION_USE_NSIS=ON -DHOST_BINARY_DIR=${{ github.workspace }}/build-host'
         cmakeAppendedArgs: ' -GNinja -DOPTION_USE_NSIS=ON -DHOST_BINARY_DIR=${{ github.workspace }}/build-host -DCMAKE_BUILD_TYPE=RelWithDebInfo'
     - name: Build (without installer)
       if: needs.source.outputs.is_tag != 'true' || matrix.arch == 'arm64'
@@ @@ -502,8 +500,7 @@ jobs: @@
         cmakeListsOrSettingsJson: CMakeListsTxtAdvanced
         useVcpkgToolchainFile: true
         buildDirectory: '${{ github.workspace }}/build'
         cmakeBuildType: RelWithDebInfo
         cmakeAppendedArgs: ' -GNinja -DHOST_BINARY_DIR=${{ github.workspace }}/build-host'
         cmakeAppendedArgs: ' -GNinja -DHOST_BINARY_DIR=${{ github.workspace }}/build-host -DCMAKE_BUILD_TYPE=RelWithDebInfo'
     - name: Create bundles
       shell: bash

0 comments (0 inline, 0 general)