cpp/openttd-patchpack/source Changeset - r16827:62a8145fde4d

Changeset - r16827:62a8145fde4d

Parent rev.

Child rev.

[Not reviewed]

master

0 6 0

alberth - 14 years ago 2010-12-21 15:23:54
alberth@openttd.org

(svn r21571) -Codechange: Having a break after a return is no good.

6 files changed with 3 insertions and 6 deletions:

src/ai/api/ai_engine.cpp

src/ai/api/ai_event_types.cpp

src/ai/api/ai_order.cpp

src/network/network_server.cpp

src/os/windows/win32.cpp

src/rail_gui.cpp

0 comments (0 inline, 0 general)

src/ai/api/ai_engine.cpp

➞

Show inline comments

@@ @@ -100,7 +100,6 @@ @@
 		case VEH_SHIP:
 		case VEH_AIRCRAFT:
 			return e->GetDisplayDefaultCapacity();
 			break;
 		default: NOT_REACHED();
+	}

src/ai/api/ai_event_types.cpp

➞

Show inline comments

@@ @@ -61,7 +61,6 @@ int32 AIEventEnginePreview::GetCapacity( @@
 		case VEH_SHIP:
 		case VEH_AIRCRAFT:
 			return e->GetDisplayDefaultCapacity();
 			break;
 		default: NOT_REACHED();
+	}

src/ai/api/ai_order.cpp

➞

Show inline comments

@@ @@ -33,7 +33,7 @@ static OrderType GetOrderTypeByTile(Tile @@
 			if (IsBuoy(t) || IsRailWaypoint(t)) return OT_GOTO_WAYPOINT;
 			if (IsHangar(t)) return OT_GOTO_DEPOT;
 			return OT_GOTO_STATION;
-			break;
 		case MP_WATER:   if (::IsShipDepot(t)) return OT_GOTO_DEPOT; break;
 		case MP_ROAD:    if (::GetRoadTileType(t) == ROAD_TILE_DEPOT) return OT_GOTO_DEPOT; break;
 		case MP_RAILWAY:

src/network/network_server.cpp

➞

Show inline comments

@@ @@ -1270,7 +1270,6 @@ DEF_GAME_RECEIVE_COMMAND(Server, PACKET_ @@
 		default:
 			IConsolePrintF(CC_ERROR, "WARNING: invalid chat action from client %d (IP: %s).", ci->client_id, GetClientIP(ci));
 			return this->SendError(NETWORK_ERROR_NOT_EXPECTED);
 			break;
+	}
 	return NETWORK_RECV_STATUS_OKAY;
+}

src/os/windows/win32.cpp

➞

Show inline comments

@@ @@ -718,7 +718,7 @@ HRESULT OTTDSHGetFolderPath(HWND hwnd, i @@
 				_tcsncat(pszPath, _T("\\Fonts"), MAX_PATH);
 				return (HRESULT)0;
-				break;
 			/* XXX - other types to go here when needed... */
+		}
+	}

src/rail_gui.cpp

➞

Show inline comments

@@ @@ -680,7 +680,7 @@ struct BuildRailToolbarWindow : Window { @@
 				/* If it is the removal button that has been clicked, do nothing,
 				 * as it is up to the other buttons to drive removal status */
 				return;
-				break;
 			case RTW_BUILD_NS:
 			case RTW_BUILD_X:
 			case RTW_BUILD_EW:

0 comments (0 inline, 0 general)