cpp/openttd-patchpack/source Changeset - r890:6c6d68bed021

Changeset - r890:6c6d68bed021

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

bjarni - 19 years ago 2005-01-04 17:54:16
bjarni@openttd.org

(svn r1376) fixed an issue where a modified client could try to replace a vehicle to an invalid engine ID and crash the server. Now the server just rejects the request. Also added a check for vehicle ownership, so you should not be able to replace other player's vehicles

1 file changed with 10 insertions and 0 deletions:

vehicle.c

0 comments (0 inline, 0 general)

vehicle.c

➞

Show inline comments

@@ @@ -1415,8 +1415,18 @@ int32 CmdReplaceVehicle(int x, int y, ui @@
 	SET_EXPENSES_TYPE(EXPENSES_NEW_VEHICLES);
 	// first we make sure that it's a valid type the user requested
 	// check that it's an engine that is in the engine array
 	if (new_engine_type >= TOTAL_NUM_ENGINES ) return CMD_ERROR;
 	// check that the new vehicle type is the same as the original one
 	if (v->type != _engines[new_engine_type].type) return CMD_ERROR;
 	// check that it's the vehicle's owner that requested the replace
 	if (!CheckOwnership(v->owner)) return CMD_ERROR;
 	switch (v->type) {
 		case VEH_Train:    build_cost = EstimateTrainCost(RailVehInfo(new_engine_type)); break;
 		case VEH_Road:     build_cost = EstimateRoadVehCost(new_engine_type);            break;

0 comments (0 inline, 0 general)