Changeset - r16992:6ce9cb0c911c
[Not reviewed]
master
0 1 0
frosch - 13 years ago 2011-01-06 22:27:56
frosch@openttd.org
(svn r21738) -Fix (r21642)[FS#4384]: Start loading when cur_order_index points to the destination station, i.e. after deleting not-reached automatic orders.
1 file changed with 6 insertions and 4 deletions:
0 comments (0 inline, 0 general)
src/vehicle.cpp
Show inline comments
 
@@ -1741,22 +1741,24 @@ uint GetVehicleCapacity(const Vehicle *v
 
void Vehicle::BeginLoading()
 
{
 
	assert(IsTileType(tile, MP_STATION) || type == VEH_SHIP);
 

	
 
	if (this->current_order.IsType(OT_GOTO_STATION) &&
 
			this->current_order.GetDestination() == this->last_station_visited) {
 
		current_order.MakeLoading(true);
 
		UpdateVehicleTimetable(this, true);
 

	
 
		/* Delete all automatic orders which were not reached */
 
		const Order *order = this->GetOrder(this->cur_order_index);
 
		while (order != NULL && order->IsType(OT_AUTOMATIC)) {
 
			/* Delete order effectively deletes order, so get the next before deleting it. */
 
			order = order->next;
 
			DeleteOrder(this, this->cur_order_index);
 
		}
 

	
 
		/* Now cur_order_index points to the destination station, and we can start loading */
 
		this->current_order.MakeLoading(true);
 
		UpdateVehicleTimetable(this, true);
 

	
 
		/* Furthermore add the Non Stop flag to mark that this station
 
		 * is the actual destination of the vehicle, which is (for example)
 
		 * necessary to be known for HandleTrainLoading to determine
 
		 * whether the train is lost or not; not marking a train lost
 
		 * that arrives at random stations is bad. */
 
		this->current_order.SetNonStopType(ONSF_NO_STOP_AT_ANY_STATION);
 
@@ -1771,13 +1773,13 @@ void Vehicle::BeginLoading()
 
				in_list->GetDestination() != this->last_station_visited)))) {
 
			Order *auto_order = new Order();
 
			auto_order->MakeAutomatic(this->last_station_visited);
 
			InsertOrder(this, auto_order, this->cur_order_index);
 
			if (this->cur_order_index > 0) --this->cur_order_index;
 
		}
 
		current_order.MakeLoading(false);
 
		this->current_order.MakeLoading(false);
 
	}
 

	
 
	Station::Get(this->last_station_visited)->loading_vehicles.push_back(this);
 

	
 
	PrepareUnload(this);
 

	
0 comments (0 inline, 0 general)