cpp/openttd-patchpack/source Changeset - r5748:714773389af6

Changeset - r5748:714773389af6

Parent rev.

Child rev.

[Not reviewed]

master

0 2 0

bjarni - 17 years ago 2007-01-21 01:25:59
bjarni@openttd.org

(svn r8296) -Fix: GenerateVehicleSortList() tried to put a TileIndex into an uint16
-Fix: CmdMassStartStopVehicle() tried to put a TileIndex into an uint16
Those two bugs were unrelated to each other and unrelated to r8295, even though that commit touched the code in question

2 files changed with 3 insertions and 3 deletions:

src/vehicle.cpp

src/vehicle.h

0 comments (0 inline, 0 general)

src/vehicle.cpp

➞

Show inline comments

@@ @@ -1621,7 +1621,7 @@ int32 CmdMassStartStopVehicle(TileIndex @@
+	}
 	if (vehicle_list_window) {
-		uint16 id = GB(p1, 0, 16);
+		uint32 id = p1;
 		uint16 window_type = p2 & VLW_MASK;
 		engine_count = GenerateVehicleSortList((const Vehicle***)&vl, &engine_list_length, vehicle_type, _current_player, id, window_type);
@@ @@ -2369,7 +2369,7 @@ void BuildDepotVehicleList(byte type, Ti @@
 * @param window_type tells what kind of window the list is for. Use the VLW flags in vehicle_gui.h
 * @return the number of vehicles added to the list
 */
-uint GenerateVehicleSortList(const Vehicle ***sort_list, uint16 *length_of_array, byte type, PlayerID owner, uint16 index, uint16 window_type)
+uint GenerateVehicleSortList(const Vehicle ***sort_list, uint16 *length_of_array, byte type, PlayerID owner, uint32 index, uint16 window_type)
+{
 	const uint subtype = (type != VEH_Aircraft) ? Train_Front : 2;
 	uint n = 0;

src/vehicle.h

➞

Show inline comments

@@ @@ -333,7 +333,7 @@ int CheckTrainStoppedInDepot(const Vehic @@
 bool VehicleNeedsService(const Vehicle *v);
-uint GenerateVehicleSortList(const Vehicle*** sort_list, uint16 *length_of_array, byte type, PlayerID owner, uint16 index, uint16 window_type);
+uint GenerateVehicleSortList(const Vehicle*** sort_list, uint16 *length_of_array, byte type, PlayerID owner, uint32 index, uint16 window_type);
 void BuildDepotVehicleList(byte type, TileIndex tile, Vehicle ***engine_list, uint16 *engine_list_length, uint16 *engine_count, Vehicle ***wagon_list, uint16 *wagon_list_length, uint16 *wagon_count);
 int32 SendAllVehiclesToDepot(byte type, uint32 flags, bool service, PlayerID owner, uint16 vlw_flag, uint32 id);
 bool IsVehicleInDepot(const Vehicle *v);

0 comments (0 inline, 0 general)