cpp/openttd-patchpack/source Changeset - r25290:a0820263314a

Changeset - r25290:a0820263314a

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

Patric Stout - 3 years ago 2021-04-27 17:58:32
truebrain@openttd.org

Codechange: be explicit in pointer comparisons

1 file changed with 1 insertions and 1 deletions:

src/network/core/game_info.cpp

0 comments (0 inline, 0 general)

src/network/core/game_info.cpp

➞

Show inline comments

@@ @@ -103,7 +103,7 @@ bool IsNetworkCompatibleVersion(const ch @@
 	const char *hash1 = ExtractNetworkRevisionHash(GetNetworkRevisionString());
 	const char *hash2 = ExtractNetworkRevisionHash(other);
-	return hash1 && hash2 && (strncmp(hash1, hash2, GITHASH_SUFFIX_LEN) == 0);
+	return hash1 != nullptr && hash2 != nullptr && strncmp(hash1, hash2, GITHASH_SUFFIX_LEN) == 0;
+}
 /**

0 comments (0 inline, 0 general)