cpp/openttd-patchpack/source Changeset - r8650:a2162c17e10b

Changeset - r8650:a2162c17e10b

Parent rev.

Child rev.

[Not reviewed]

master

0 4 0

glx - 16 years ago 2008-02-27 21:46:57
glx@openttd.org

(svn r12296) -Fix [FS#1549]: restore timetable from backupped orders and add group ID to the backup

4 files changed with 25 insertions and 3 deletions:

src/group_cmd.cpp

src/order.h

src/order_cmd.cpp

src/timetable_cmd.cpp

0 comments (0 inline, 0 general)

src/group_cmd.cpp

➞

Show inline comments

@@ @@ -134,6 +134,9 @@ CommandCost CmdDeleteGroup(TileIndex til @@
 			if (v->group_id == g->index && v->type == g->vehicle_type) v->group_id = DEFAULT_GROUP;
+		}
 		/* Update backupped orders if needed */
 		if (_backup_orders_data.group == g->index) _backup_orders_data.group = DEFAULT_GROUP;
 		/* If we set an autoreplace for the group we delete, remove it. */
 		if (_current_player < MAX_PLAYERS) {
 			Player *p;

src/order.h

➞

Show inline comments

@@ @@ -126,6 +126,7 @@ struct BackuppedOrders { @@
 	VehicleID clone;
 	VehicleOrderID orderindex;
 	GroupID group;
 	Order *order;
 	uint16 service_interval;
 	char *name;

src/order_cmd.cpp

➞

Show inline comments

@@ @@ -933,6 +933,7 @@ void BackupVehicleOrders(const Vehicle * @@
 	/* Save general info */
 	bak->orderindex       = v->cur_order_index;
 	bak->group            = v->group_id;
 	bak->service_interval = v->service_interval;
 	if (v->name != NULL) bak->name = strdup(v->name);
@@ @@ -992,13 +993,24 @@ void RestoreVehicleOrders(const Vehicle @@
 		 *  fails in test mode. By bypassing the test-mode, that no longer is a problem. */
 		for (uint i = 0; bak->order[i].IsValid(); i++) {
 			if (!DoCommandP(0, v->index + (i << 16), PackOrder(&bak->order[i]), NULL,
 					CMD_INSERT_ORDER | CMD_NO_TEST_IF_IN_NETWORK))
+					CMD_INSERT_ORDER | CMD_NO_TEST_IF_IN_NETWORK)) {
 				break;
+			}
 			/* Copy timetable */
 			if (!DoCommandP(0, v->index | (i << 16) | (1 << 25),
 					bak->order[i].wait_time << 16 | bak->order[i].travel_time, NULL,
 					CMD_CHANGE_TIMETABLE | CMD_NO_TEST_IF_IN_NETWORK)) {
 				break;
+			}
+		}
+	}
 	/* Restore vehicle order-index and service interval */
 	DoCommandP(0, v->index, bak->orderindex | (bak->service_interval << 16) , NULL, CMD_RESTORE_ORDER_INDEX);
 	/* Restore vehicle group */
 	DoCommandP(0, bak->group, v->index, NULL, CMD_ADD_VEHICLE_GROUP);
+}
 /** Restore the current order-index of a vehicle and sets service-interval.

src/timetable_cmd.cpp

➞

Show inline comments

@@ @@ -46,7 +46,11 @@ static void ChangeTimetable(Vehicle *v, @@
  * - p1 = (bit 16-23) - Order index to modify.
  * - p1 = (bit    24) - Whether to change the waiting time or the travelling
  *                      time.
  * - p1 = (bit    25) - Whether p2 contains waiting and travelling time.
  * @param p2 The amount of time to wait.
  * - p2 = (bit  0-15) - Waiting or travelling time as specified by p1 bit 24 if p1 bit 25 is not set,
  *                      Travelling time if p1 bit 25 is set.
  * - p2 = (bit 16-31) - Waiting time if p1 bit 25 is set
  */
 CommandCost CmdChangeTimetable(TileIndex tile, uint32 flags, uint32 p1, uint32 p2)
+{
@@ @@ -62,14 +66,16 @@ CommandCost CmdChangeTimetable(TileIndex @@
 	Order *order = GetVehicleOrder(v, order_number);
 	if (order == NULL) return CMD_ERROR;
 	bool is_journey = HasBit(p1, 24);
 	bool packed_time = HasBit(p1, 25);
 	bool is_journey = HasBit(p1, 24) || packed_time;
 	if (!is_journey) {
 		if (order->type != OT_GOTO_STATION) return_cmd_error(STR_TIMETABLE_ONLY_WAIT_AT_STATIONS);
 		if (_patches.new_nonstop && (order->flags & OFB_NON_STOP)) return_cmd_error(STR_TIMETABLE_NOT_STOPPING_HERE);
+	}
 	if (flags & DC_EXEC) {
 		ChangeTimetable(v, order_number, p2, is_journey);
 		ChangeTimetable(v, order_number, GB(p2, 0, 16), is_journey);
 		if (packed_time) ChangeTimetable(v, order_number, GB(p2, 16, 16), false);
+	}
 	return CommandCost();

0 comments (0 inline, 0 general)