cpp/openttd-patchpack/source Changeset - r27576:b346340fe4e3

Changeset - r27576:b346340fe4e3

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

Rubidium - 15 months ago 2023-06-13 13:49:12
rubidium@openttd.org

Codechange: pass zero length arguments for {STRING}, instead of the remaining arguments

1 file changed with 2 insertions and 4 deletions:

src/strings.cpp

0 comments (0 inline, 0 general)

src/strings.cpp

➞

Show inline comments

@@ @@ -1087,10 +1087,8 @@ static void FormatString(StringBuilder & @@
 			case SCC_STRING: {// {STRING}
 				StringID string_id = args->GetInt32(SCC_STRING);
 				if (game_script && GetStringTab(string_id) != TEXT_TAB_GAMESCRIPT_START) break;
 				/* WARNING. It's prohibited for the included string to consume any arguments.
 				 * For included strings that consume argument, you should use STRING1, STRING2 etc.
 				 * To debug stuff you can set argv to nullptr and it will tell you */
 				StringParameters tmp_params(args->GetDataPointer(), args->GetDataLeft(), nullptr);
 				/* It's prohibited for the included string to consume any arguments. */
 				StringParameters tmp_params(*args, 0);
 				GetStringWithArgs(builder, string_id, &tmp_params, next_substr_case_index, game_script);
 				next_substr_case_index = 0;
 				break;

0 comments (0 inline, 0 general)