cpp/openttd-patchpack/source Changeset - r8573:c66e03190d64

Changeset - r8573:c66e03190d64

Parent rev.

Child rev.

[Not reviewed]

master

0 7 0

glx - 16 years ago 2008-02-15 23:57:03
glx@openttd.org

(svn r12154) -Codechange: removed a magic number

7 files changed with 10 insertions and 8 deletions:

src/ai/default/default.cpp

src/airport_gui.cpp

src/dock_gui.cpp

src/rail_gui.cpp

src/road_gui.cpp

src/station.h

src/station_cmd.cpp

0 comments (0 inline, 0 general)

src/ai/default/default.cpp

➞

Show inline comments

@@ @@ -1604,7 +1604,7 @@ static void AiStateWantNewRoute(Player * @@
 static bool AiCheckTrackResources(TileIndex tile, const AiDefaultBlockData *p, byte cargo)
+{
-	uint rad = (_patches.modified_catchment) ? CA_TRAIN : 4;
+	uint rad = (_patches.modified_catchment) ? CA_TRAIN : CA_UNMODIFIED;
 	for (; p->mode != 4; p++) {
 		AcceptedCargo values;
@@ @@ -3409,7 +3409,7 @@ static bool AiCheckAirportResources(Tile @@
 		const AirportFTAClass* airport = GetAirport(p->attr);
 		uint w = airport->size_x;
 		uint h = airport->size_y;
-		uint rad = _patches.modified_catchment ? airport->catchment : 4;
+		uint rad = _patches.modified_catchment ? airport->catchment : CA_UNMODIFIED;
 		if (cargo & 0x80) {
 			GetProductionAroundTiles(values, tile2, w, h, rad);

src/airport_gui.cpp

➞

Show inline comments

@@ @@ -179,7 +179,7 @@ static void BuildAirportPickerWndProc(Wi @@
 		airport = GetAirport(_selected_airport_type);
 		SetTileSelectSize(airport->size_x, airport->size_y);
-		int rad = _patches.modified_catchment ? airport->catchment : 4;
+		int rad = _patches.modified_catchment ? airport->catchment : CA_UNMODIFIED;
 		if (_station_show_coverage) SetTileSelectBigSize(-rad, -rad, 2 * rad, 2 * rad);

src/dock_gui.cpp

➞

Show inline comments

@@ @@ -243,7 +243,7 @@ static void BuildDockStationWndProc(Wind @@
 	case WE_CREATE: w->LowerWidget(_station_show_coverage + 3); break;
 	case WE_PAINT: {
-		int rad = (_patches.modified_catchment) ? CA_DOCK : 4;
+		int rad = (_patches.modified_catchment) ? CA_DOCK : CA_UNMODIFIED;
 		if (WP(w, def_d).close) return;
 		DrawWindowWidgets(w);

src/rail_gui.cpp

➞

Show inline comments

@@ @@ -818,7 +818,7 @@ static void StationBuildWndProc(Window * @@
 				SetTileSelectSize(x, y);
+		}
-		int rad = (_patches.modified_catchment) ? CA_TRAIN : 4;
+		int rad = (_patches.modified_catchment) ? CA_TRAIN : CA_UNMODIFIED;
 		if (_station_show_coverage)
 			SetTileSelectBigSize(-rad, -rad, 2 * rad, 2 * rad);

src/road_gui.cpp

➞

Show inline comments

@@ @@ -809,7 +809,7 @@ static void RoadStationPickerWndProc(Win @@
 		DrawWindowWidgets(w);
 		if (_station_show_coverage) {
-			int rad = _patches.modified_catchment ? CA_TRUCK /* = CA_BUS */ : 4;
+			int rad = _patches.modified_catchment ? CA_TRUCK /* = CA_BUS */ : CA_UNMODIFIED;
 			SetTileSelectBigSize(-rad, -rad, 2 * rad, 2 * rad);
 		} else {
 			SetTileSelectSize(1, 1);

src/station.h

➞

Show inline comments

@@ @@ -239,6 +239,8 @@ enum CatchmentArea { @@
 	CA_TRAIN           =  4,
 	CA_DOCK            =  5,
 	CA_UNMODIFIED      =  4, ///< Used when _patches.modified_catchment is false
 	MAX_CATCHMENT      = 10, ///< Airports have a catchment up to this number.
 };

src/station_cmd.cpp

➞

Show inline comments

@@ @@ -599,7 +599,7 @@ static void UpdateStationAcceptance(Stat @@
 			TileXY(rect.min_x, rect.min_y),
 			rect.max_x - rect.min_x + 1,
 			rect.max_y - rect.min_y + 1,
-			_patches.modified_catchment ? FindCatchmentRadius(st) : 4
+			_patches.modified_catchment ? FindCatchmentRadius(st) : CA_UNMODIFIED
 		);
 	} else {
 		memset(accepts, 0, sizeof(accepts));
@@ @@ -2712,7 +2712,7 @@ StationSet FindStationsAroundIndustryTil @@
 		h_prod = 0;
 		w += 8;
 		h += 8;
-		max_rad = 4;
+		max_rad = CA_UNMODIFIED;
+	}
 	BEGIN_TILE_LOOP(cur_tile, w, h, tile - TileDiffXY(max_rad, max_rad))

0 comments (0 inline, 0 general)