cpp/openttd-patchpack/source Changeset - r23227:cad899bc5508

Changeset - r23227:cad899bc5508

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

Peter Nelson - 6 years ago 2019-01-27 12:35:14
peter1138@openttd.org

Codechange: Rename function to match what it does and reduce code indenting.

1 file changed with 6 insertions and 7 deletions:

src/group_gui.cpp

0 comments (0 inline, 0 general)

src/group_gui.cpp

➞

Show inline comments

@@ @@ -122,14 +122,13 @@ private: @@
 	Dimension column_size[VGC_END]; ///< Size of the columns in the group list.
-	void AddParents(GUIGroupList *source, GroupID parent, int indent)
+	void AddChildren(GUIGroupList *source, GroupID parent, int indent)
+	{
 		for (const Group **g = source->Begin(); g != source->End(); g++) {
 			if ((*g)->parent == parent) {
 				*this->groups.Append() = *g;
 				*this->indents.Append() = indent;
 				AddParents(source, (*g)->index, indent + 1);
+			}
 			if ((*g)->parent != parent) continue;
 			*this->groups.Append() = *g;
 			*this->indents.Append() = indent;
 			AddChildren(source, (*g)->index, indent + 1);
+		}
+	}
@@ @@ -180,7 +179,7 @@ private: @@
 		list.ForceResort();
 		list.Sort(&GroupNameSorter);
-		AddParents(&list, INVALID_GROUP, 0);
+		AddChildren(&list, INVALID_GROUP, 0);
 		this->groups.Compact();
 		this->groups.RebuildDone();

0 comments (0 inline, 0 general)