cpp/openttd-patchpack/source Changeset - r9582:cb7711765a81

Changeset - r9582:cb7711765a81

Parent rev.

Child rev.

[Not reviewed]

master

0 3 0

smatz - 16 years ago 2008-06-24 09:15:45
smatz@openttd.org

(svn r13619) -Codechange: use 'const char *' instead of std::string for blitter and driver names
Removes indirect dependency on <string> for 20 files, reduces binary size by 16kB

3 files changed with 33 insertions and 10 deletions:

src/blitter/factory.hpp

src/driver.cpp

src/driver.h

0 comments (0 inline, 0 general)

src/blitter/factory.hpp

➞

Show inline comments

 /* $Id$ */
 /** @file factory.hpp Factory to 'query' all available blitters. */
 #ifndef BLITTER_FACTORY_HPP
 #define BLITTER_FACTORY_HPP
 #include "base.hpp"
 #include "../debug.h"
 #include "../string_func.h"
 #include <string>
 #include <map>
 /**
  * The base factory, keeping track of all blitters.
  */
 class BlitterFactoryBase {
 private:
 	char *name;
 	typedef std::map<std::string, BlitterFactoryBase *> Blitters;
 	const char *name;
 	struct StringCompare {
 		bool operator () (const char *a, const char *b) const
+		{
 			return strcmp(a, b) < 0;
+		}
 	};
 	typedef std::map<const char *, BlitterFactoryBase *, StringCompare> Blitters;
 	static Blitters &GetBlitters()
+	{
 		static Blitters &s_blitters = *new Blitters();
 		return s_blitters;
+	}
 	static Blitter **GetActiveBlitter()
+	{
 		static Blitter *s_blitter = NULL;
 		return &s_blitter;
+	}
@@ @@ -49,25 +56,25 @@ protected: @@
+	}
 public:
 	BlitterFactoryBase() :
 		name(NULL)
 	{}
 	virtual ~BlitterFactoryBase()
+	{
 		if (this->name == NULL) return;
 		GetBlitters().erase(this->name);
 		if (GetBlitters().empty()) delete &GetBlitters();
 		free(this->name);
+		free((void *)this->name);
+	}
 	/**
 	 * Find the requested blitter and return his class.
 	 * @param name the blitter to select.
 	 * @post Sets the blitter so GetCurrentBlitter() returns it too.
 	 */
 	static Blitter *SelectBlitter(const char *name)
+	{
 		const char *default_blitter = "8bpp-optimized";
 #if defined(__APPLE__)

src/driver.cpp

➞

Show inline comments

@@ @@ -147,25 +147,27 @@ void DriverFactoryBase::RegisterDriver(c @@
 	/* Don't register nameless Drivers */
 	if (name == NULL) return;
 	this->name = strdup(name);
 	this->type = type;
 	this->priority = priority;
 	/* Prefix the name with driver type to make it unique */
 	char buf[32];
 	strecpy(buf, GetDriverTypeName(type), lastof(buf));
 	strecpy(buf + 5, name, lastof(buf));
 	std::pair<Drivers::iterator, bool> P = GetDrivers().insert(Drivers::value_type(buf, this));
 	const char *longname = strdup(buf);
 	std::pair<Drivers::iterator, bool> P = GetDrivers().insert(Drivers::value_type(longname, this));
 	assert(P.second);
+}
 /**
  * Build a human readable list of available drivers, grouped by type.
  */
 char *DriverFactoryBase::GetDriversInfo(char *p, const char *last)
+{
 	for (Driver::Type type = Driver::DT_BEGIN; type != Driver::DT_END; type++) {
 		p += snprintf(p, last - p, "List of %s drivers:\n", GetDriverTypeName(type));
 		for (int priority = 10; priority >= 0; priority--) {
@@ @@ -185,16 +187,23 @@ char *DriverFactoryBase::GetDriversInfo( @@
+}
 /** Frees memory used for this->name
  */
 DriverFactoryBase::~DriverFactoryBase() {
 	if (this->name == NULL) return;
 	/* Prefix the name with driver type to make it unique */
 	char buf[32];
 	strecpy(buf, GetDriverTypeName(type), lastof(buf));
 	strecpy(buf + 5, this->name, lastof(buf));
 	GetDrivers().erase(buf);
 	Drivers::iterator it = GetDrivers().find(buf);
 	assert(it != GetDrivers().end());
 	const char *longname = (*it).first;
 	GetDrivers().erase(it);
 	free((void *)longname);
 	if (GetDrivers().empty()) delete &GetDrivers();
 	free(this->name);
+	free((void *)this->name);
+}

src/driver.h

➞

Show inline comments

 /* $Id$ */
 /** @file driver.h Base for all drivers (video, sound, music, etc). */
 #ifndef DRIVER_H
 #define DRIVER_H
 #include "debug.h"
 #include "core/enum_type.hpp"
 #include "string_func.h"
 #include <string>
 #include <map>
 bool GetDriverParamBool(const char * const *parm, const char *name);
 int GetDriverParamInt(const char * const *parm, const char *name, int def);
 class Driver {
 public:
 	virtual const char *Start(const char * const *parm) = 0;
 	virtual void Stop() = 0;
 	virtual ~Driver() { }
@@ @@ -28,27 +27,35 @@ public: @@
 		DT_MUSIC,
 		DT_VIDEO,
 		DT_END,
 	};
 };
 DECLARE_POSTFIX_INCREMENT(Driver::Type);
 class DriverFactoryBase {
 private:
 	Driver::Type type;
 	char *name;
+	const char *name;
 	int priority;
 	typedef std::map<std::string, DriverFactoryBase *> Drivers;
 	struct StringCompare {
 		bool operator () (const char *a, const char *b) const
+		{
 			return strcmp(a, b) < 0;
+		}
 	};
 	typedef std::map<const char *, DriverFactoryBase *, StringCompare> Drivers;
 	static Drivers &GetDrivers()
+	{
 		static Drivers &s_drivers = *new Drivers();
 		return s_drivers;
+	}
 	static Driver **GetActiveDriver(Driver::Type type)
+	{
 		static Driver *s_driver[3] = { NULL, NULL, NULL };
 		return &s_driver[type];
+	}

0 comments (0 inline, 0 general)