cpp/openttd-patchpack/source Changeset - r25977:e1f4fbb88a36

Changeset - r25977:e1f4fbb88a36

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

Patric Stout - 3 years ago 2021-09-19 20:52:46
truebrain@openttd.org

Add: [Network] On join, log the ClientID + IP + Name clearly (#9558)

Additionally, reword the disconnect to match connect / join messages.

Co-authored-by: Berbe <4251220+Berbe@users.noreply.github.com>

1 file changed with 3 insertions and 1 deletions:

src/network/network_server.cpp

0 comments (0 inline, 0 general)

src/network/network_server.cpp

➞

Show inline comments

@@ @@ -278,13 +278,13 @@ NetworkRecvStatus ServerNetworkGameSocke @@
 		this->savegame = nullptr;
 		this->CheckNextClientToSendMap(this);
+	}
 	NetworkAdminClientError(this->client_id, NETWORK_ERROR_CONNECTION_LOST);
-	Debug(net, 3, "Closed client connection {}", this->client_id);
+	Debug(net, 3, "[{}] Client #{} closed connection", ServerNetworkGameSocketHandler::GetName(), this->client_id);
 	/* We just lost one client :( */
 	if (this->status >= STATUS_AUTHORIZED) _network_game_info.clients_on--;
 	extern byte _network_clients_connected;
 	_network_clients_connected--;
@@ @@ -945,12 +945,14 @@ NetworkRecvStatus ServerNetworkGameSocke @@
 	if (this->status == STATUS_DONE_MAP && !this->HasClientQuit()) {
 		std::string client_name = this->GetClientName();
 		NetworkTextMessage(NETWORK_ACTION_JOIN, CC_DEFAULT, false, client_name, "", this->client_id);
 		InvalidateWindowData(WC_CLIENT_LIST, 0);
 		Debug(net, 3, "[{}] Client #{} ({}) joined as {}", ServerNetworkGameSocketHandler::GetName(), this->client_id, this->GetClientIP(), client_name);
 		/* Mark the client as pre-active, and wait for an ACK
 		 *  so we know it is done loading and in sync with us */
 		this->status = STATUS_PRE_ACTIVE;
 		NetworkHandleCommandQueue(this);
 		this->SendFrame();
 		this->SendSync();

0 comments (0 inline, 0 general)