cpp/openttd-patchpack/source Changeset - r26796:eb34f7242c64

Changeset - r26796:eb34f7242c64

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

PeterN - 17 months ago 2023-01-24 00:05:42
peter1138@openttd.org

Fix #10220: Don't select unselectable engine as default. (#10404)

1 file changed with 6 insertions and 6 deletions:

src/build_vehicle_gui.cpp

0 comments (0 inline, 0 general)

src/build_vehicle_gui.cpp

➞

Show inline comments

@@ @@ -1188,12 +1188,12 @@ struct BuildVehicleWindow : Window { @@
 		this->eng_list.ForceRebuild();
 		this->GenerateBuildList(); // generate the list, since we need it in the next line
 		/* Select the first engine in the list as default when opening the window */
 		if (this->eng_list.size() > 0) {
 			this->SelectEngine(this->eng_list[0].engine_id);
 		} else {
 			this->SelectEngine(INVALID_ENGINE);
+		}
 		/* Select the first unshaded engine in the list as default when opening the window */
 		EngineID engine = INVALID_ENGINE;
 		auto it = std::find_if(this->eng_list.begin(), this->eng_list.end(), [&](GUIEngineListItem &item){ return (item.flags & EngineDisplayFlags::Shaded) == EngineDisplayFlags::None; });
 		if (it != this->eng_list.end()) engine = it->engine_id;
 		this->SelectEngine(engine);
+	}
 	/** Set the filter type according to the depot type */

0 comments (0 inline, 0 general)