cpp/openttd-patchpack/source Changeset - r28173:efb82ca52a2b

Changeset - r28173:efb82ca52a2b

Parent rev.

Child rev.

[Not reviewed]

master

0 2 0

Peter Nelson - 12 months ago 2023-11-24 21:51:35
peter1138@openttd.org

Codechange: Undo #11447, drop down list divider lines are now explicit.

2 files changed with 4 insertions and 8 deletions:

src/widgets/dropdown.cpp

src/widgets/dropdown_type.h

0 comments (0 inline, 0 general)

src/widgets/dropdown.cpp

➞

Show inline comments

@@ @@ -48,14 +48,10 @@ uint DropDownListStringItem::Width() con @@
 	return GetStringBoundingBox(this->String()).width + WidgetDimensions::scaled.dropdowntext.Horizontal();
+}
-void DropDownListStringItem::Draw(const Rect &r, bool sel, Colours bg_colour) const
 void DropDownListStringItem::Draw(const Rect &r, bool sel, Colours) const
+{
 	if (this->String().empty()) {
 		this->DropDownListItem::Draw(r, sel, bg_colour);
 	} else {
 		Rect ir = r.Shrink(WidgetDimensions::scaled.dropdowntext);
 		DrawString(ir.left, ir.right, r.top, this->String(), sel ? TC_WHITE : TC_BLACK);
+	}
 	Rect ir = r.Shrink(WidgetDimensions::scaled.dropdowntext);
 	DrawString(ir.left, ir.right, r.top, this->String(), sel ? TC_WHITE : TC_BLACK);
+}
 /**

src/widgets/dropdown_type.h

➞

Show inline comments

@@ @@ -42,7 +42,7 @@ public: @@
 	DropDownListStringItem(StringID string, int result, bool masked);
 	DropDownListStringItem(const std::string &string, int result, bool masked);
-	bool Selectable() const override { return !this->String().empty(); }
+	bool Selectable() const override { return true; }
 	uint Width() const override;
 	void Draw(const Rect &r, bool sel, Colours bg_colour) const override;
 	virtual const std::string &String() const { return this->string; }

0 comments (0 inline, 0 general)