cpp/openttd-patchpack/source Changeset - r24421:f178a9589b1f

Changeset - r24421:f178a9589b1f

Parent rev.

Child rev.

[Not reviewed]

master

0 1 0

Patric Stout - 4 years ago 2020-12-08 22:11:47
truebrain@openttd.org

Codechange: to create or not to create a folder, that is the question

This was just weird. With XDG _personal_dir was created already,
but later on it was checked if it was different from config_dir,
and the creation was skipped. All this checking and validation
makes my head spin .. let's make it a bit more simple.

1 file changed with 2 insertions and 3 deletions:

src/fileio.cpp

0 comments (0 inline, 0 general)

src/fileio.cpp

➞

Show inline comments

@@ @@ -1234,7 +1234,6 @@ void DeterminePaths(const char *exe) @@
 		/* We are using the XDG configuration home for the config file,
 		 * then store the rest in the XDG data home folder. */
 		_personal_dir = _searchpaths[SP_PERSONAL_DIR_XDG];
 		FioCreateDirectory(_personal_dir);
 	} else
 #endif
+	{
@@ @@ -1242,9 +1241,9 @@ void DeterminePaths(const char *exe) @@
+	}
 	/* Make the necessary folders */
 	FioCreateDirectory(config_dir);
 #if defined(WITH_PERSONAL_DIR)
 	FioCreateDirectory(config_dir);
 	if (config_dir != _personal_dir) FioCreateDirectory(_personal_dir);
 	FioCreateDirectory(_personal_dir);
 #endif
 	DEBUG(misc, 3, "%s found as personal directory", _personal_dir);

0 comments (0 inline, 0 general)