cpp/openttd-patchpack/source Changeset - r23244:f49fdf9fd43c

Changeset - r23244:f49fdf9fd43c

Parent rev.

Child rev.

[Not reviewed]

master

0 4 0

J0an Josep - 6 years ago 2019-01-14 21:34:59
juanjo.ng.83@gmail.com

Cleanup: [NPF] Remove unused parameters.

4 files changed with 7 insertions and 11 deletions:

src/pathfinder/npf/npf.cpp

src/pathfinder/npf/npf_func.h

src/ship_cmd.cpp

src/train_cmd.cpp

0 comments (0 inline, 0 general)

src/pathfinder/npf/npf.cpp

➞

Show inline comments

@@ @@ -1154,7 +1154,7 @@ Trackdir NPFRoadVehicleChooseTrack(const @@
 /*** Ships ***/
-Track NPFShipChooseTrack(const Ship *v, TileIndex tile, DiagDirection enterdir, TrackBits tracks, bool &path_found)
 Track NPFShipChooseTrack(const Ship *v, TrackBits tracks, bool &path_found)
+{
 	NPFFindStationOrTileData fstd;
 	Trackdir trackdir = v->GetVehicleTrackdir();
@@ @@ -1163,7 +1163,7 @@ Track NPFShipChooseTrack(const Ship *v, @@
 	NPFFillWithOrderData(&fstd, v);
 	AyStarUserData user = { v->owner, TRANSPORT_WATER, INVALID_RAILTYPES, ROADTYPES_NONE };
-	NPFFoundTargetData ftd = NPFRouteToStationOrTile(tile - TileOffsByDiagDir(enterdir), trackdir, true, &fstd, &user);
+	NPFFoundTargetData ftd = NPFRouteToStationOrTile(v->tile, trackdir, true, &fstd, &user);
 	/* If ftd.best_bird_dist is 0, we found our target and ftd.best_trackdir contains
 	 * the direction we need to take to get there, if ftd.best_bird_dist is not 0,
@@ @@ -1256,7 +1256,7 @@ bool NPFTrainCheckReverse(const Train *v @@
 	return ftd.best_bird_dist == 0 && NPFGetFlag(&ftd.node, NPF_FLAG_REVERSE);
+}
-Track NPFTrainChooseTrack(const Train *v, TileIndex tile, DiagDirection enterdir, TrackBits tracks, bool &path_found, bool reserve_track, struct PBSTileInfo *target)
 Track NPFTrainChooseTrack(const Train *v, TrackBits tracks, bool &path_found, bool reserve_track, struct PBSTileInfo *target)
+{
 	NPFFindStationOrTileData fstd;
 	NPFFillWithOrderData(&fstd, v, reserve_track);

src/pathfinder/npf/npf_func.h

➞

Show inline comments

@@ @@ -41,13 +41,11 @@ Trackdir NPFRoadVehicleChooseTrack(const @@
 /**
  * Finds the best path for given ship using NPF.
  * @param v        the ship that needs to find a path
  * @param tile     the tile to find the path from (should be next tile the ship is about to enter)
  * @param enterdir diagonal direction which the ship will enter this new tile from
  * @param tracks   available tracks on the new tile (to choose from)
  * @param path_found [out] Whether a path has been found (true) or has been guessed (false)
  * @return         the best trackdir for next turn or INVALID_TRACK if the path could not be found
  */
-Track NPFShipChooseTrack(const Ship *v, TileIndex tile, DiagDirection enterdir, TrackBits tracks, bool &path_found);
 Track NPFShipChooseTrack(const Ship *v, TrackBits tracks, bool &path_found);
 /**
  * Returns true if it is better to reverse the ship before leaving depot using NPF.
@@ @@ -87,14 +85,12 @@ bool NPFTrainCheckReverse(const Train *v @@
 /**
  * Finds the best path for given train using NPF.
  * @param v        the train that needs to find a path
  * @param tile     the tile to find the path from (should be next tile the train is about to enter)
  * @param enterdir diagonal direction which the RV will enter this new tile from
  * @param tracks   available trackdirs on the new tile (to choose from)
  * @param path_found [out] Whether a path has been found (true) or has been guessed (false)
  * @param reserve_track indicates whether YAPF should try to reserve the found path
  * @param target   [out] the target tile of the reservation, free is set to true if path was reserved
  * @return         the best track for next turn
  */
-Track NPFTrainChooseTrack(const Train *v, TileIndex tile, DiagDirection enterdir, TrackBits tracks, bool &path_found, bool reserve_track, struct PBSTileInfo *target);
 Track NPFTrainChooseTrack(const Train *v, TrackBits tracks, bool &path_found, bool reserve_track, struct PBSTileInfo *target);
 #endif /* NPF_FUNC_H */

src/ship_cmd.cpp

➞

Show inline comments

@@ @@ -491,7 +491,7 @@ static Track ChooseShipTrack(Ship *v, Ti @@
 		switch (_settings_game.pf.pathfinder_for_ships) {
 			case VPF_OPF: track = OPFShipChooseTrack(v, tile, enterdir, tracks, path_found); break;
-			case VPF_NPF: track = NPFShipChooseTrack(v, tile, enterdir, tracks, path_found); break;
 			case VPF_NPF: track = NPFShipChooseTrack(v, tracks, path_found); break;
 			case VPF_YAPF: track = YapfShipChooseTrack(v, tile, enterdir, tracks, path_found, v->path); break;
 			default: NOT_REACHED();
+		}

src/train_cmd.cpp

➞

Show inline comments

@@ @@ -2313,7 +2313,7 @@ static const byte _initial_tile_subcoord @@
 static Track DoTrainPathfind(const Train *v, TileIndex tile, DiagDirection enterdir, TrackBits tracks, bool &path_found, bool do_track_reservation, PBSTileInfo *dest)
+{
 	switch (_settings_game.pf.pathfinder_for_trains) {
-		case VPF_NPF: return NPFTrainChooseTrack(v, tile, enterdir, tracks, path_found, do_track_reservation, dest);
 		case VPF_NPF: return NPFTrainChooseTrack(v, tracks, path_found, do_track_reservation, dest);
 		case VPF_YAPF: return YapfTrainChooseTrack(v, tile, enterdir, tracks, path_found, do_track_reservation, dest);
 		default: NOT_REACHED();

0 comments (0 inline, 0 general)