diff --git a/src/network/network_stun.cpp b/src/network/network_stun.cpp --- a/src/network/network_stun.cpp +++ b/src/network/network_stun.cpp @@ -100,9 +100,7 @@ NetworkRecvStatus ClientNetworkStunSocke { NetworkStunSocketHandler::CloseConnection(error); - /* If our connecter is still pending, shut it down too. Otherwise the - * callback of the connecter can call into us, and our object is most - * likely about to be destroyed. */ + /* Also make sure any pending connecter is killed ASAP. */ if (this->connecter != nullptr) { this->connecter->Kill(); this->connecter = nullptr; @@ -111,6 +109,14 @@ NetworkRecvStatus ClientNetworkStunSocke return NETWORK_RECV_STATUS_OKAY; } +ClientNetworkStunSocketHandler::~ClientNetworkStunSocketHandler() +{ + if (this->connecter != nullptr) { + this->connecter->Kill(); + this->connecter = nullptr; + } +} + /** * Check whether we received/can send some data from/to the STUN server and * when that's the case handle it appropriately.