Files
@ r27008:1819ba4d5c84
Branch filter:
Location: cpp/openttd-patchpack/source/src/waypoint_func.h - annotation
r27008:1819ba4d5c84
1021 B
text/x-c
Fix: crashes to desktop from game scripts when companies disappear
When a game script is in company mode, it pretends to be another company. When
that company disappear (bankruptcy/merger), the game script still uses that
company and it keeps calling functions as if it is that company.
For example, ScriptEngine::IsBuildable internally dereferences Company without
checks, causing a null dereference for any ScriptEngine function when called
from a company scope of a company that has disappeared.
Guard against this by extending the ScriptCompanyScope::IsValid check to also
check for the company still being active.
When a game script is in company mode, it pretends to be another company. When
that company disappear (bankruptcy/merger), the game script still uses that
company and it keeps calling functions as if it is that company.
For example, ScriptEngine::IsBuildable internally dereferences Company without
checks, causing a null dereference for any ScriptEngine function when called
from a company scope of a company that has disappeared.
Guard against this by extending the ScriptCompanyScope::IsValid check to also
check for the company still being active.
r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 r12528:f4d1c0776108 r12465:c1b760a56db7 r12476:b14b8e966cd2 r12476:b14b8e966cd2 r12552:8db41d79d6a8 r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 | /*
* This file is part of OpenTTD.
* OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
* OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
*/
/** @file waypoint_func.h Functions related to waypoints. */
#ifndef WAYPOINT_FUNC_H
#define WAYPOINT_FUNC_H
#include "rail_type.h"
#include "command_type.h"
#include "station_type.h"
CommandCost RemoveBuoy(TileIndex tile, DoCommandFlag flags);
Axis GetAxisForNewWaypoint(TileIndex tile);
void ShowWaypointWindow(const Waypoint *wp);
void DrawWaypointSprite(int x, int y, int stat_id, RailType railtype);
#endif /* WAYPOINT_FUNC_H */
|