Files @ r24271:c20a6e3dcfe0
Branch filter:

Location: cpp/openttd-patchpack/source/src/network/core/tcp_connect.cpp - annotation

Jonathan G Rennison
Fix: Racy use of flags in TCPConnecter::CheckCallbacks

conected and aborted flags are used concurrently from multiple threads.
r12768:980ae0491352
r12768:980ae0491352
r12768:980ae0491352
r12768:980ae0491352
r12768:980ae0491352
r12768:980ae0491352
r12768:980ae0491352
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r23587:821735a25dec
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r21383:942c32fb8b0e
r21383:942c32fb8b0e
r10828:d8d68d002525
r23538:8df50944b27a
r10828:d8d68d002525
r17138:5078c9240593
r17138:5078c9240593
r17138:5078c9240593
r17138:5078c9240593
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r23532:dc91fcd293f5
r23607:36c15679007d
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r17138:5078c9240593
r10828:d8d68d002525
r10828:d8d68d002525
r11550:baebd05afdd5
r10828:d8d68d002525
r10828:d8d68d002525
r11550:baebd05afdd5
r11550:baebd05afdd5
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r17138:5078c9240593
r17138:5078c9240593
r17138:5078c9240593
r17138:5078c9240593
r23587:821735a25dec
r10828:d8d68d002525
r23587:821735a25dec
r10828:d8d68d002525
r10828:d8d68d002525
r17138:5078c9240593
r17138:5078c9240593
r17138:5078c9240593
r17138:5078c9240593
r17138:5078c9240593
r17138:5078c9240593
r10828:d8d68d002525
r10828:d8d68d002525
r23531:603769aaf687
r10828:d8d68d002525
r24271:c20a6e3dcfe0
r24271:c20a6e3dcfe0
r24271:c20a6e3dcfe0
r23531:603769aaf687
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r24271:c20a6e3dcfe0
r23531:603769aaf687
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r24271:c20a6e3dcfe0
r23531:603769aaf687
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r10828:d8d68d002525
r17138:5078c9240593
r10828:d8d68d002525
r10828:d8d68d002525
r23536:ce42deb0b32d
r10828:d8d68d002525
/*
 * This file is part of OpenTTD.
 * OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
 * OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 * See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
 */

/**
 * @file tcp_connect.cpp Basic functions to create connections without blocking.
 */

#include "../../stdafx.h"
#include "../../thread.h"

#include "tcp.h"

#include "../../safeguards.h"

/** List of connections that are currently being created */
static std::vector<TCPConnecter *> _tcp_connecters;

/**
 * Create a new connecter for the given address
 * @param address the (un)resolved address to connect to
 */
TCPConnecter::TCPConnecter(const NetworkAddress &address) :
	connected(false),
	aborted(false),
	killed(false),
	sock(INVALID_SOCKET),
	address(address)
{
	_tcp_connecters.push_back(this);
	if (!StartNewThread(nullptr, "ottd:tcp", &TCPConnecter::ThreadEntry, this)) {
		this->Connect();
	}
}

/** The actual connection function */
void TCPConnecter::Connect()
{
	this->sock = this->address.Connect();
	if (this->sock == INVALID_SOCKET) {
		this->aborted = true;
	} else {
		this->connected = true;
	}
}

/**
 * Entry point for the new threads.
 * @param param the TCPConnecter instance to call Connect on.
 */
/* static */ void TCPConnecter::ThreadEntry(TCPConnecter *param)
{
	param->Connect();
}

/**
 * Check whether we need to call the callback, i.e. whether we
 * have connected or aborted and call the appropriate callback
 * for that. It's done this way to ease on the locking that
 * would otherwise be needed everywhere.
 */
/* static */ void TCPConnecter::CheckCallbacks()
{
	for (auto iter = _tcp_connecters.begin(); iter < _tcp_connecters.end(); /* nothing */) {
		TCPConnecter *cur = *iter;
		const bool connected = cur->connected.load();
		const bool aborted = cur->aborted.load();
		if ((connected || aborted) && cur->killed) {
			iter = _tcp_connecters.erase(iter);
			if (cur->sock != INVALID_SOCKET) closesocket(cur->sock);
			delete cur;
			continue;
		}
		if (connected) {
			iter = _tcp_connecters.erase(iter);
			cur->OnConnect(cur->sock);
			delete cur;
			continue;
		}
		if (aborted) {
			iter = _tcp_connecters.erase(iter);
			cur->OnFailure();
			delete cur;
			continue;
		}
		iter++;
	}
}

/** Kill all connection attempts. */
/* static */ void TCPConnecter::KillAll()
{
	for (TCPConnecter *conn : _tcp_connecters) conn->killed = true;
}