Files
@ r24498:e9114d9ab04a
Branch filter:
Location: cpp/openttd-patchpack/source/src/base_consist.cpp - annotation
r24498:e9114d9ab04a
1.9 KiB
text/x-c
Fix #6468: don't store version of AIs-started-via-console in name
You can do: "startai myai.3", which starts version 3 of "myai".
This is very useful for testing save/load code between different
versions of your AI.
However, when using this syntax, the AI got saved as "myai.3" as
name of the AI, instead of "myai". This caused several problems,
like indicating to the user the AI could not be found, but still
load the AI. But in all cases, the AI never got the chance to
load the saved data, making the whole reason this exists pointless.
By splitting the name and version already in the console command,
the code becomes simpler and AIs started this way now follow the
normal flow after initialization.
You can do: "startai myai.3", which starts version 3 of "myai".
This is very useful for testing save/load code between different
versions of your AI.
However, when using this syntax, the AI got saved as "myai.3" as
name of the AI, instead of "myai". This caused several problems,
like indicating to the user the AI could not be found, but still
load the AI. But in all cases, the AI never got the chance to
load the saved data, making the whole reason this exists pointless.
By splitting the name and version already in the console command,
the code becomes simpler and AIs started this way now follow the
normal flow after initialization.
r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19521:9abf5bbcc05a r21410:ae5961f02724 r19517:63a2bec6c0ee r21383:942c32fb8b0e r21383:942c32fb8b0e r19518:752c1c3f7cfd r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r19517:63a2bec6c0ee r24214:a65c412aafcc r19518:752c1c3f7cfd r19521:9abf5bbcc05a r19521:9abf5bbcc05a r19521:9abf5bbcc05a r19521:9abf5bbcc05a r19517:63a2bec6c0ee r19521:9abf5bbcc05a r19517:63a2bec6c0ee r19521:9abf5bbcc05a r19521:9abf5bbcc05a r19521:9abf5bbcc05a r19521:9abf5bbcc05a r19521:9abf5bbcc05a r22109:4f5568bb92f8 r22109:4f5568bb92f8 r22109:4f5568bb92f8 r22109:4f5568bb92f8 r19517:63a2bec6c0ee | /*
* This file is part of OpenTTD.
* OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
* OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
*/
/** @file base_consist.cpp Properties for front vehicles/consists. */
#include "stdafx.h"
#include "base_consist.h"
#include "vehicle_base.h"
#include "string_func.h"
#include "safeguards.h"
/**
* Copy properties of other BaseConsist.
* @param src Source for copying
*/
void BaseConsist::CopyConsistPropertiesFrom(const BaseConsist *src)
{
if (this == src) return;
this->name = src->name;
this->current_order_time = src->current_order_time;
this->lateness_counter = src->lateness_counter;
this->timetable_start = src->timetable_start;
this->service_interval = src->service_interval;
this->cur_real_order_index = src->cur_real_order_index;
this->cur_implicit_order_index = src->cur_implicit_order_index;
if (HasBit(src->vehicle_flags, VF_TIMETABLE_STARTED)) SetBit(this->vehicle_flags, VF_TIMETABLE_STARTED);
if (HasBit(src->vehicle_flags, VF_AUTOFILL_TIMETABLE)) SetBit(this->vehicle_flags, VF_AUTOFILL_TIMETABLE);
if (HasBit(src->vehicle_flags, VF_AUTOFILL_PRES_WAIT_TIME)) SetBit(this->vehicle_flags, VF_AUTOFILL_PRES_WAIT_TIME);
if (HasBit(src->vehicle_flags, VF_SERVINT_IS_PERCENT) != HasBit(this->vehicle_flags, VF_SERVINT_IS_PERCENT)) {
ToggleBit(this->vehicle_flags, VF_SERVINT_IS_PERCENT);
}
if (HasBit(src->vehicle_flags, VF_SERVINT_IS_CUSTOM)) SetBit(this->vehicle_flags, VF_SERVINT_IS_CUSTOM);
}
|