Files
@ r28513:ea5142b3c09b
Branch filter:
Location: cpp/openttd-patchpack/source/src/os/unix/font_unix.cpp - annotation
r28513:ea5142b3c09b
6.0 KiB
text/x-c
Fix 09f585b: Crash if font name ends with comma or comma and whitespace on Linux. (#11838)
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 | r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r28513:ea5142b3c09b r28513:ea5142b3c09b r27601:272d990bb25f r27601:272d990bb25f r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27147:5d938ed2c7b5 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r24761:9595588c0322 r27482:151ee53cd970 r27601:272d990bb25f r24761:9595588c0322 r27482:151ee53cd970 r27601:272d990bb25f r27601:272d990bb25f r27482:151ee53cd970 r27482:151ee53cd970 r27601:272d990bb25f r27601:272d990bb25f r27601:272d990bb25f r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r24761:9595588c0322 r27601:272d990bb25f r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r24761:9595588c0322 r27482:151ee53cd970 r27601:272d990bb25f r24761:9595588c0322 r27482:151ee53cd970 r28074:fffdbfe84aad r28074:fffdbfe84aad r27482:151ee53cd970 r27482:151ee53cd970 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27482:151ee53cd970 r24761:9595588c0322 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27942:f7389062d120 r24761:9595588c0322 r27482:151ee53cd970 r24761:9595588c0322 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r27482:151ee53cd970 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27542:44cebefe4f42 r24761:9595588c0322 r24761:9595588c0322 r27541:98de37403e2e r27657:0b6cf1e99420 r27657:0b6cf1e99420 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27657:0b6cf1e99420 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27657:0b6cf1e99420 r27657:0b6cf1e99420 r27657:0b6cf1e99420 r27657:0b6cf1e99420 r27657:0b6cf1e99420 r27657:0b6cf1e99420 r24761:9595588c0322 r24761:9595588c0322 r27415:cd7d225c26b7 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27657:0b6cf1e99420 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27657:0b6cf1e99420 r26399:db15b808f86d r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r24761:9595588c0322 r27482:151ee53cd970 r24761:9595588c0322 r24761:9595588c0322 | /*
* This file is part of OpenTTD.
* OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
* OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
*/
/** @file font_unix.cpp Functions related to font handling on Unix/Fontconfig. */
#include "../../stdafx.h"
#include "../../debug.h"
#include "../../fontdetection.h"
#include "../../string_func.h"
#include "../../strings_func.h"
#include <fontconfig/fontconfig.h>
#include "safeguards.h"
#include <ft2build.h>
#include FT_FREETYPE_H
extern FT_Library _library;
/**
* Split the font name into the font family and style. These fields are separated by a comma,
* but the style does not necessarily need to exist.
* @param font_name The font name.
* @return The font family and style.
*/
static std::tuple<std::string, std::string> SplitFontFamilyAndStyle(std::string_view font_name)
{
auto separator = font_name.find(',');
if (separator == std::string_view::npos) return { std::string(font_name), std::string() };
auto begin = font_name.find_first_not_of("\t ", separator + 1);
if (begin == std::string_view::npos) return { std::string(font_name.substr(0, separator)), std::string() };
return { std::string(font_name.substr(0, separator)), std::string(font_name.substr(begin)) };
}
FT_Error GetFontByFaceName(const char *font_name, FT_Face *face)
{
FT_Error err = FT_Err_Cannot_Open_Resource;
if (!FcInit()) {
ShowInfo("Unable to load font configuration");
return err;
}
auto fc_instance = FcConfigReference(nullptr);
assert(fc_instance != nullptr);
/* Split & strip the font's style */
auto [font_family, font_style] = SplitFontFamilyAndStyle(font_name);
/* Resolve the name and populate the information structure */
FcPattern *pat = FcNameParse((FcChar8 *)font_family.data());
if (!font_style.empty()) FcPatternAddString(pat, FC_STYLE, (FcChar8 *)font_style.data());
FcConfigSubstitute(nullptr, pat, FcMatchPattern);
FcDefaultSubstitute(pat);
FcFontSet *fs = FcFontSetCreate();
FcResult result;
FcPattern *match = FcFontMatch(nullptr, pat, &result);
if (fs != nullptr && match != nullptr) {
FcChar8 *family;
FcChar8 *style;
FcChar8 *file;
int32_t index;
FcFontSetAdd(fs, match);
for (int i = 0; err != FT_Err_Ok && i < fs->nfont; i++) {
/* Try the new filename */
if (FcPatternGetString(fs->fonts[i], FC_FILE, 0, &file) == FcResultMatch &&
FcPatternGetString(fs->fonts[i], FC_FAMILY, 0, &family) == FcResultMatch &&
FcPatternGetString(fs->fonts[i], FC_STYLE, 0, &style) == FcResultMatch &&
FcPatternGetInteger(fs->fonts[i], FC_INDEX, 0, &index) == FcResultMatch) {
/* The correct style? */
if (!font_style.empty() && !StrEqualsIgnoreCase(font_style, (char *)style)) continue;
/* Font config takes the best shot, which, if the family name is spelled
* wrongly a 'random' font, so check whether the family name is the
* same as the supplied name */
if (StrEqualsIgnoreCase(font_family, (char *)family)) {
err = FT_New_Face(_library, (char *)file, index, face);
}
}
}
}
FcPatternDestroy(pat);
FcFontSetDestroy(fs);
FcConfigDestroy(fc_instance);
return err;
}
bool SetFallbackFont(FontCacheSettings *settings, const std::string &language_isocode, int, MissingGlyphSearcher *callback)
{
bool ret = false;
if (!FcInit()) return ret;
auto fc_instance = FcConfigReference(nullptr);
assert(fc_instance != nullptr);
/* Fontconfig doesn't handle full language isocodes, only the part
* before the _ of e.g. en_GB is used, so "remove" everything after
* the _. */
std::string lang = fmt::format(":lang={}", language_isocode.substr(0, language_isocode.find('_')));
/* First create a pattern to match the wanted language. */
FcPattern *pat = FcNameParse((const FcChar8 *)lang.c_str());
/* We only want to know these attributes. */
FcObjectSet *os = FcObjectSetBuild(FC_FILE, FC_INDEX, FC_SPACING, FC_SLANT, FC_WEIGHT, nullptr);
/* Get the list of filenames matching the wanted language. */
FcFontSet *fs = FcFontList(nullptr, pat, os);
/* We don't need these anymore. */
FcObjectSetDestroy(os);
FcPatternDestroy(pat);
if (fs != nullptr) {
int best_weight = -1;
const char *best_font = nullptr;
int best_index = 0;
for (int i = 0; i < fs->nfont; i++) {
FcPattern *font = fs->fonts[i];
FcChar8 *file = nullptr;
FcResult res = FcPatternGetString(font, FC_FILE, 0, &file);
if (res != FcResultMatch || file == nullptr) {
continue;
}
/* Get a font with the right spacing .*/
int value = 0;
FcPatternGetInteger(font, FC_SPACING, 0, &value);
if (callback->Monospace() != (value == FC_MONO) && value != FC_DUAL) continue;
/* Do not use those that explicitly say they're slanted. */
FcPatternGetInteger(font, FC_SLANT, 0, &value);
if (value != 0) continue;
/* We want the fatter font as they look better at small sizes. */
FcPatternGetInteger(font, FC_WEIGHT, 0, &value);
if (value <= best_weight) continue;
/* Possible match based on attributes, get index. */
int32_t index;
res = FcPatternGetInteger(font, FC_INDEX, 0, &index);
if (res != FcResultMatch) continue;
callback->SetFontNames(settings, (const char *)file, &index);
bool missing = callback->FindMissingGlyphs();
Debug(fontcache, 1, "Font \"{}\" misses{} glyphs", (char *)file, missing ? "" : " no");
if (!missing) {
best_weight = value;
best_font = (const char *)file;
best_index = index;
}
}
if (best_font != nullptr) {
ret = true;
callback->SetFontNames(settings, best_font, &best_index);
InitFontCache(callback->Monospace());
}
/* Clean up the list of filenames. */
FcFontSetDestroy(fs);
}
FcConfigDestroy(fc_instance);
return ret;
}
|