cpp/openttd-patchpack/source Files · .github/stale.yml

Files @ r23483:3733e6b8ff17

Branch filter:

Location: cpp/openttd-patchpack/source/.github/stale.yml

r23483:3733e6b8ff17 939 B text/x-yaml Show Annotation Show as Raw Download as Raw

Patric Stout

Remove: ENABLE_NETWORK switch

This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.

Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.

A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.

With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.

All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.

daysUntilClose: 7
staleLabel: stale
closeComment: false
exemptMilestones: true
exemptAssignees: true

issues:
  daysUntilStale: 60
  exemptLabels:
  - pinned
  - security
  - "good first issue"
  - regression
  markComment: >
    This issue has been automatically marked as stale because it has not had any activity in the last two months.

    If you believe the issue is still relevant, please test on the latest nightly and report back.

    It will be closed if no further activity occurs within 7 days.

    Thank you for your contributions.

pulls:
  daysUntilStale: 30
  exemptLabels:
  - pinned
  markComment: >
    This pull request has been automatically marked as stale because it has not had any activity in the last month.

    Please feel free to give a status update now, ping for review, or re-open when it's ready.

    It will be closed if no further activity occurs within 7 days.

    Thank you for your contributions.