cpp/openttd-patchpack/source Files · src/cpu.h

Files @ r23483:3733e6b8ff17

Branch filter:

Location: cpp/openttd-patchpack/source/src/cpu.h

r23483:3733e6b8ff17 1.4 KiB text/x-c Show Annotation Show as Raw Download as Raw

Patric Stout

Remove: ENABLE_NETWORK switch

This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.

Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.

A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.

With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.

All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.

/* $Id$ */

/*
 * This file is part of OpenTTD.
 * OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
 * OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 * See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
 */

/** @file cpu.h Functions related to CPU specific instructions. */

#ifndef CPU_H
#define CPU_H

/**
 * Get the tick counter from the CPU (high precision timing).
 * @return The count.
 */
uint64 ottd_rdtsc();

/**
 * Get the CPUID information from the CPU.
 * @param info The retrieved info. All zeros on architectures without CPUID.
 * @param type The information this instruction should retrieve.
 */
void ottd_cpuid(int info[4], int type);

/**
 * Check whether the current CPU has the given flag.
 * @param type  The type to be passing to cpuid (usually 1).
 * @param index The index in the returned info array.
 * @param bit   The bit index that needs to be set.
 * @return The value of the bit, or false when there is no CPUID or the type is not available.
 */
bool HasCPUIDFlag(uint type, uint index, uint bit);

#endif /* CPU_H */