Files
@ r24498:e9114d9ab04a
Branch filter:
Location: cpp/openttd-patchpack/source/src/waypoint_base.h - annotation
r24498:e9114d9ab04a
2.2 KiB
text/x-c
Fix #6468: don't store version of AIs-started-via-console in name
You can do: "startai myai.3", which starts version 3 of "myai".
This is very useful for testing save/load code between different
versions of your AI.
However, when using this syntax, the AI got saved as "myai.3" as
name of the AI, instead of "myai". This caused several problems,
like indicating to the user the AI could not be found, but still
load the AI. But in all cases, the AI never got the chance to
load the saved data, making the whole reason this exists pointless.
By splitting the name and version already in the console command,
the code becomes simpler and AIs started this way now follow the
normal flow after initialization.
You can do: "startai myai.3", which starts version 3 of "myai".
This is very useful for testing save/load code between different
versions of your AI.
However, when using this syntax, the AI got saved as "myai.3" as
name of the AI, instead of "myai". This caused several problems,
like indicating to the user the AI could not be found, but still
load the AI. But in all cases, the AI never got the chance to
load the saved data, making the whole reason this exists pointless.
By splitting the name and version already in the console command,
the code becomes simpler and AIs started this way now follow the
normal flow after initialization.
r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12465:c1b760a56db7 r12465:c1b760a56db7 r16851:b5784600e35e r16851:b5784600e35e r12465:c1b760a56db7 r12467:b4ba97896a21 r12465:c1b760a56db7 r17624:f2c5f47dceaa r18730:83ef302fe140 r16110:0eb4e685b16c r12465:c1b760a56db7 r17624:f2c5f47dceaa r17624:f2c5f47dceaa r17624:f2c5f47dceaa r17624:f2c5f47dceaa r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 r23497:a0ab44ebd2fa r12465:c1b760a56db7 r23787:94603685a34b r23787:94603685a34b r23497:a0ab44ebd2fa r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 r12465:c1b760a56db7 r23497:a0ab44ebd2fa r12465:c1b760a56db7 r23497:a0ab44ebd2fa r12493:6da69ce1ff42 r23497:a0ab44ebd2fa r12493:6da69ce1ff42 r12493:6da69ce1ff42 r12493:6da69ce1ff42 r12493:6da69ce1ff42 r23497:a0ab44ebd2fa r12493:6da69ce1ff42 r12493:6da69ce1ff42 r12493:6da69ce1ff42 r14560:a63b9e37c39e r14560:a63b9e37c39e r14560:a63b9e37c39e r14560:a63b9e37c39e r14560:a63b9e37c39e r18782:6453522c2154 r14560:a63b9e37c39e r14560:a63b9e37c39e r14560:a63b9e37c39e r15159:901498571693 r15159:901498571693 r15159:901498571693 r15159:901498571693 r15159:901498571693 r15159:901498571693 r15159:901498571693 r18782:6453522c2154 r15159:901498571693 r15159:901498571693 r15159:901498571693 r12465:c1b760a56db7 r12465:c1b760a56db7 r16851:b5784600e35e | /*
* This file is part of OpenTTD.
* OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
* OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
*/
/** @file waypoint_base.h Base of waypoints. */
#ifndef WAYPOINT_BASE_H
#define WAYPOINT_BASE_H
#include "base_station_base.h"
/** Representation of a waypoint. */
struct Waypoint FINAL : SpecializedStation<Waypoint, true> {
uint16 town_cn; ///< The N-1th waypoint for this town (consecutive number)
/**
* Create a waypoint at the given tile.
* @param tile The location of the waypoint.
*/
Waypoint(TileIndex tile = INVALID_TILE) : SpecializedStation<Waypoint, true>(tile) { }
~Waypoint();
void UpdateVirtCoord() override;
void MoveSign(TileIndex new_xy) override;
inline bool TileBelongsToRailStation(TileIndex tile) const override
{
return IsRailWaypointTile(tile) && GetStationIndex(tile) == this->index;
}
uint32 GetNewGRFVariable(const struct ResolverObject &object, byte variable, byte parameter, bool *available) const override;
void GetTileArea(TileArea *ta, StationType type) const override;
uint GetPlatformLength(TileIndex tile, DiagDirection dir) const override
{
return 1;
}
uint GetPlatformLength(TileIndex tile) const override
{
return 1;
}
/**
* Is this a single tile waypoint?
* @return true if it is.
*/
inline bool IsSingleTile() const
{
return (this->facilities & FACIL_TRAIN) != 0 && this->train_station.w == 1 && this->train_station.h == 1;
}
/**
* Is the "type" of waypoint the same as the given waypoint,
* i.e. are both a rail waypoint or are both a buoy?
* @param wp The waypoint to compare to.
* @return true iff their types are equal.
*/
inline bool IsOfType(const Waypoint *wp) const
{
return this->string_id == wp->string_id;
}
};
#endif /* WAYPOINT_BASE_H */
|