Files
@ r24498:e9114d9ab04a
Branch filter:
Location: cpp/openttd-patchpack/source/src/signs.cpp - annotation
r24498:e9114d9ab04a
1.7 KiB
text/x-c
Fix #6468: don't store version of AIs-started-via-console in name
You can do: "startai myai.3", which starts version 3 of "myai".
This is very useful for testing save/load code between different
versions of your AI.
However, when using this syntax, the AI got saved as "myai.3" as
name of the AI, instead of "myai". This caused several problems,
like indicating to the user the AI could not be found, but still
load the AI. But in all cases, the AI never got the chance to
load the saved data, making the whole reason this exists pointless.
By splitting the name and version already in the console command,
the code becomes simpler and AIs started this way now follow the
normal flow after initialization.
You can do: "startai myai.3", which starts version 3 of "myai".
This is very useful for testing save/load code between different
versions of your AI.
However, when using this syntax, the AI got saved as "myai.3" as
name of the AI, instead of "myai". This caused several problems,
like indicating to the user the AI could not be found, but still
load the AI. But in all cases, the AI never got the chance to
load the saved data, making the whole reason this exists pointless.
By splitting the name and version already in the console command,
the code becomes simpler and AIs started this way now follow the
normal flow after initialization.
r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r12768:980ae0491352 r9111:983de9c5a848 r6420:01087f989fd1 r5584:545d748cc681 r6453:b0b56773284a r8790:550c9960067a r8790:550c9960067a r8114:866ed489ed98 r11967:df0600d2c7e7 r23942:2580b984b22e r5584:545d748cc681 r8264:d493cb51fe8a r8264:d493cb51fe8a r21383:942c32fb8b0e r21383:942c32fb8b0e r17625:366001a31c88 r11967:df0600d2c7e7 r11967:df0600d2c7e7 r7384:aaaa0c017200 r17099:f140f6165f35 r17099:f140f6165f35 r17099:f140f6165f35 r10207:a1fc2f2a33db r5584:545d748cc681 r8258:08100da56269 r5584:545d748cc681 r5584:545d748cc681 r17099:f140f6165f35 r7384:aaaa0c017200 r7384:aaaa0c017200 r10156:5d97c842d2d7 r10156:5d97c842d2d7 r10156:5d97c842d2d7 r7384:aaaa0c017200 r7384:aaaa0c017200 r5584:545d748cc681 r5584:545d748cc681 r5584:545d748cc681 r12381:5e06b887e97b r5584:545d748cc681 r12381:5e06b887e97b r23942:2580b984b22e r23942:2580b984b22e r23942:2580b984b22e r12381:5e06b887e97b r18465:95d781aa9dc8 r23942:2580b984b22e r23942:2580b984b22e r5584:545d748cc681 r5584:545d748cc681 r10571:99cb9a95b4cf r6247:96e840dbefcc r5584:545d748cc681 r23970:272c50d4cd26 r12381:5e06b887e97b r12381:5e06b887e97b r5584:545d748cc681 | /*
* This file is part of OpenTTD.
* OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
* OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
*/
/** @file signs.cpp Handling of signs. */
#include "stdafx.h"
#include "landscape.h"
#include "signs_base.h"
#include "signs_func.h"
#include "strings_func.h"
#include "core/pool_func.hpp"
#include "viewport_kdtree.h"
#include "table/strings.h"
#include "safeguards.h"
/** Initialize the sign-pool */
SignPool _sign_pool("Sign");
INSTANTIATE_POOL_METHODS(Sign)
/**
* Creates a new sign
*/
Sign::Sign(Owner owner)
{
this->owner = owner;
}
/** Destroy the sign */
Sign::~Sign()
{
if (CleaningPool()) return;
DeleteRenameSignWindow(this->index);
}
/**
* Update the coordinate of one sign
*/
void Sign::UpdateVirtCoord()
{
Point pt = RemapCoords(this->x, this->y, this->z);
if (this->sign.kdtree_valid) _viewport_sign_kdtree.Remove(ViewportSignKdtreeItem::MakeSign(this->index));
SetDParam(0, this->index);
this->sign.UpdatePosition(pt.x, pt.y - 6 * ZOOM_LVL_BASE, STR_WHITE_SIGN);
_viewport_sign_kdtree.Insert(ViewportSignKdtreeItem::MakeSign(this->index));
}
/** Update the coordinates of all signs */
void UpdateAllSignVirtCoords()
{
for (Sign *si : Sign::Iterate()) {
si->UpdateVirtCoord();
}
}
|