Change: Use CARGO_LIST to show station cargo acceptance changes. (#11379)

This simplifies construction of the news message and allows for more than
two changes to be show in one line.

Codechange: Avoid emplace_back(new()) into a unique_ptr. (#11384)

This could theoretically leave an unmanaged pointer in certain circumstances, and directly using
make_unique shows intent.

Codechange: Use max_element to find best cargo (sub-)type in NewGRF var 42. (#11370)

This replaces two manual loops to find the best cargo (sub-)type.

Codechange: Use std::map instead of fixed array to store refit options.

This simplifies handling of available refit options.

Codechange: Use comparator struct to sort cargo ID by predefined sort order.

This allows reuse of the comparator where a typename is used instead.

Codechange: Add const versions of GetItem/GetGroup, and sprinkle liberally.

Non-const version of GetItem is not needed.

Codechange: Use range-for instead of nullptr-terminated list in settingsgen.

This simplifies iteration and avoids use of pointers.

Codechange: Use std::list instead of C-linked list for ini files.

This removes self-management of memory with new/delete and allows simpler iteration.

Codechange: Remove create parameter from IniLoadFile::GetGroup.

GetGroup now only returns nullptr if the group does not exist.
Use GetOrCreateGroup to create a group.

This avoids creating groups while reading ini files.

Codechange: Split GetGroup into GetGroup/GetOrCreateGroup.

This follows the pattern used for GetItem/GetOrCreateItem, and allows use
of references where we know the group must exist.

Codechange: Add CreateGroup/CreateItem methods for ini files.

This abstracts the internals a bit.

Codechange: Pass ini file by reference and prefer automatic storage.

This avoids new/delete operations, and (not) checking for nullptr.

Codechange: Use bitmask instead of array for cargo consistency check.

We only need to know if a cargo type is accepted, not how much.

Fix: Assertion in sprite aligner window (#11371)

When clicking sprite number after re-opening window having previously used sprite picker tool

Codechange: Use std::vector in fallback layouter, and shorten accessors. (#11355)

This avoids use of malloc/free (and custom move constructors), and follows how the exist layouters are written.

Update: Translations from eints
hungarian: 50 changes by Norodix

Update: Translations from eints
chinese (simplified): 5 changes by WenSimEHRP

Fix: Treat closing network relay window as a choice of "No".

Issue ConnectFailure when closing the window if the relay request is
considered unhandled.

Add: data parameter in Window::Close method.

This allows passing data when closing a window, e.g. to indicate how it was closed.

Codechange: Don't use bit-field in Yapf rail node. (#11362)

Compacting 3 booleans into 3 bits could save memory allocation, however this data is inside a union which also contains a 4-byte integer. As such this gives the cost penalty of a bit-field without any benefit.

Update: Translations from eints
chinese (traditional): 80 changes by wpi3
chinese (simplified): 1 change by WenSimEHRP

Fix 94167dfd: Don't shade the currently selected engine in autoreplace window. (#11354)

This breaks #7729 which specifically allows autoreplace of same engine types, and also did not work properly if the engine had been built during the current game session.

Update: Translations from eints
chinese (simplified): 1 change by WenSimEHRP
indonesian: 12 changes by liimee

Update: Translations from eints
romanian: 3 changes by bnegrut

Fix: Check for engine variant loops during NewGRF initialization. (#11343)

Invalid NewGRFs could set up an engine variant loop that never ends. This
was checked for in some places that evaluated variants, but not all. In
most cases this would result in the engines not appearing, but could
potentially cause an infinite loop and crash.

Instead, during NewGRF initialization detect loops and remove invalid
variants before setting display flags.

Update: Translations from eints
english (us): 1 change by 2TallTyler
vietnamese: 21 changes by KhoiCanDev

Change: Store station blocked/wires/pylons flags in map. (#11337)

This stores three flags in unused map bits, and avoids having to look up
station graphics and custom station specs to determine blocked/wires/pylons
status.

This potentially affects rail pathfinding performance.

Savegame version is not bumped, as the flags can just be updated every
time.

Update: Translations from eints
korean: 1 change by telk5093

Update: Translations from eints
italian: 25 changes by Rivarossi

Update: Translations from eints
finnish: 1 change by hpiirai

Update: Translations from eints
chinese (simplified): 139 changes by BYXxiaonanhui
catalan: 23 changes by J0anJosep
portuguese (brazilian): 1 change by pasantoro

Update: Translations from eints
english (au): 1 change by krysclarke
russian: 1 change by Ln-Wolf
danish: 1 change by bscargo
dutch: 1 change by Afoklala
french: 1 change by ottdfevr
portuguese: 1 change by azulcosta
polish: 68 changes by pAter-exe

Fix: #11329: Don't assert vehicle list length is non-zero when only asked to set string parameter. (#11330)

Since #11321, the vehicle list is not yet initialized when SetStringParameters is called, so a test that the vehicle list size is zero is triggered. However, doing this check in the SetStringParameters function is a bit out of its remit, so just remove it.

Codechange: Use std::bitset instead of bool array.

This avoids use of C-style pointers and memset.

Codechange: List fallback station names by ID instead of magic number.

This improves readability and intention of the station name generator.

Update: Translations from eints
danish: 20 changes by bscargo

Codechange: Don't access cargo filter before it is initialized. (#11321)

The cargo filter list is initialized during window OnInit, but the first
build of the filtered list occurred before this.

Codechange: Don't pass GUI cargo filter constants to command system. (#11320)

CMD_BUILD_VEHICLE expects CT_INVALID to indicate a new vehicle should not
be refitted on build, but the code passed CF_NONE instead. CF_NONE has the
same numeric value at CT_INVALID, so the test passed, but...

Codechange: All ParagraphLayoutFactory::AppendToBuffer assume that the buffer has at least some space.
Assert on that.

Fix: only count distance traveled in vehicles for cargo payment (#11283)

No longer you can utilize the free (and instant) labour of station
workers, transporting your cargo from one part of the station to
the other. No more!

Based on patch by dP.

Update: Translations from eints
korean: 1 change by telk5093

Fix #11315: Sort industries and cargoes by name* in industry chain window.

*Cargo types are sorted by the normal method so it's not strictly alphabetical.

Fix: Don't produce invalid cargo. (#11314)

Production for secondary industries did not always check that the produced cargo type isn't valid.

Codechange: use better location for the "invalid" action sentinel value

It used to be a random sentinel for end-of-(widget-)list that was used to tell
that no action has taken place yet. Since the last action is practically the
widget that was pressed, add the sentinel to that enumeration.

Fix #11307: Incorrect GroupStatistics after selling leading wagon

When this results in a countable consist

Codechange: Rename INVALID_CARGO to INVALID_CARGO_BITNUM

... to avoid future ambiguity.