Fix: Extra space allocated to container-within-container may not get allocated to children. (#11471)

Always derive additional length from contained widgets instead of from the container, as the container's minimal length may have been adjusted by an NC_EQUALSIZE parent container.

Update: Translations from eints
dutch: 1 change by Afoklala

Fix: extmidi did not move on to next song after playing ends. (#11469)

`song` is no longer a C-style string so cannot be cleared by writing a NUL char.
Use `.clear()` to properly clear a std::string.

Update: Translations from eints
french: 1 change by Lishouuu

Codechange: Move RectPadding::zero definition to header. (#11461)

This potentially allows better inlining/optimization.

Update: Translations from eints
tamil: 3 changes by Jeyanthinath

Codechange: Simplify cargo filter lists, building only when required.

Some cargo filter lists were built in advance, and used as lookups to test which cargo type to filter.

Instead, use the Cargo ID directly as the filter parameter, and build the lists only when the drop down list is used.

Update: Translations from eints
danish: 1 change by bscargo
polish: 1 change by pAter-exe

Codechange: Simplify autoreplace rail/road types by using separate widget. (#11457)

This avoids needing to determine which type of list to deal with by additionally checking the window number for VEH_TRAIN/VEH_ROAD.

Update: Translations from eints
vietnamese: 7 changes by KhoiCanDev
korean: 1 change by telk5093
catalan: 7 changes by J0anJosep

Update: Translations from eints
english (au): 1 change by krysclarke
italian: 7 changes by Rivarossi
russian: 1 change by Ln-Wolf
finnish: 1 change by hpiirai
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by pasantoro

Change: Move baseset missing/corrupted files label to list item. (#11455)

This allows any baseset error to be displayed in the drop down list so it is more easily visible, and avoids wasted space in the layout.

Codechange: Replace AllocatedStringParameters with ArrayStringParameters (#11452)

All uses of AllocatedStringParameters are with a compile-time fixed
constant.
Use of a dynamically allocated buffer on the heap is unnecessary and
increases overhead, particularly due to frequent use as a temporary.

Update: Translations from eints
german: 3 changes by SecretIdetity
romanian: 6 changes by bnegrut

Update: Translations from eints
hungarian: 54 changes by titanicbobo

Add: WidgetDimensions for 'sparse' widget windows.

These are for windows that have space between widgets instead of being clumped together.

Update: Translations from eints
chinese (simplified): 1 change by WenSimEHRP
danish: 1 change by bscargo
hindi: 111 changes by NisheshTyagi

Codechange: Add base() method to StrongType to allow access to the base type without casting. (#11445)

This removes the ability to explicitly cast to the base type, but the requirement
to use .base() means the conversion is still explicit.

Update: Translations from eints
korean: 14 changes by telk5093
polish: 1 change by pAter-exe

Change: Add horizontal scrollbar to Industry Directory window.

This list could be very wide depending on industries and language.

Codechange: Don't filter industry list by cargo type every 3-sec refresh.

The 3-sec refresh is to update the list sorting. The filter only needs to
be applied once rebuilding the list.

Codechange: Skip invisible (zero-size) widgets in PIP Containers.

This gets rid of doubled-up spacing where an invisible child widget would be.

Codechange: Add ability to allocate PIP-space dynamically by ratio.

This can be used to space out, centre, start-align, or end-align widgets without additional spacers.

Fix #11437: Flipped shorter rail vehicles disappear in windows. (#11446)

Mixed signed/unsigned strikes again, causing an incorrect sprite offset for shortened vehicles.

Codechange: Don't be lenient with invalid NWidgetPart lists.

Some NWidgetPart combinations were ignored but it was not clear that they do nothing. Instead, assert if NWidgetPart is incorrectly applied.

Add: Mock sprite cache intialization.

This fills up the sprite cache with SPR_OPENTTD_BASE + OPENTTD_SPRITE_COUNT zero-size sprites, to
allow GetSpriteSize() calls to continue from unit-tests.

Add: Expose minimal parts of SpriteCache internals.

These parts are needed to be able to mock the SpriteCache for unit-tests.

Update: Translations from eints
korean: 1 change by telk5093
finnish: 1 change by hpiirai
portuguese (brazilian): 1 change by pasantoro

Fix: Using MIN_YEAR for a date is probably wrong, Use MIN_DATE instead. (#11444)

Even with strong types ...

Update: Translations from eints
english (us): 3 changes by 2TallTyler
french: 2 changes by Lishouuu

Codechange: Replicate cursor screen backup to chat message display, removing explicit memory management.

Incidentally, this makes Blitter::GetBytesPerPixel unneeed.

Fix #9545: Crash when all cargo types are disabled. (#11432)

This is not a very useful state, but it's nice to not crash.

Some parts of the game don't (yet) check for cargo types being redefined, that is out-of-scope here.

Fix cda6f24f: don't ignore binary-dir if it happens to be working-dir (#11431)

Some of our code ignores the SP_WORKING_DIR for some actions, which
means that if, for example, your SP_BINARY_DIR is the same as your
SP_WORKING_DIR, neither is scanned.

Instead, only add SP_WORKING_DIR if it is unique.

Codechange: Avoid pointers and lengthof in ExpensesList. (#11427)

Use std::initializer_list which allows iteration.

Cleanup: Remove some unused functions. (#11429)

These were picked up with cppcheck.

Update: Translations from eints
english (au): 1 change by krysclarke
russian: 1 change by Ln-Wolf
dutch: 3 changes by Afoklala
portuguese: 1 change by azulcosta

Codechange: Add unit-test to check if nested widget parts of properly closed.

Properly closed means exactly one EndContainer for every Container widget.

Add: WindowDesc unit test to validate ini-key value.

ini-key must be present if WWT_DEFSIZEBOX or WWT_STICKYBOX is present.
This was previously enforced by a workflow, however that parsed the source
code with regex which turned out to be error-prone.

Codechange: Add __FILE__/__LINE__ of WindowDesc to WindowDesc.

This is to allow unit-tests to produce more useful output.

Fix: AI config window should not have an ini_key. (#11423)

This was missed by the workflow script that enforces this constraint.

Update: Translations from eints
finnish: 2 changes by hpiirai
danish: 1 change by bscargo

Codechange: Move includes to correct place.

Some other source file inadvertently included things via smallmap_gui.h

Revert 6b68956: Move declaration of SmallMapWindow out of header file.

This split needlessly complicates `SmallMapWindow` for the sake of one method (no longer) used by `LinkGraphOverlay`.

Fix #11413: Incorrect sorting by industry production.

Error caused by single character mistake. However this algorithm was inefficent if a filter was specified, and clearly the flow was error-prone.

Now using separately-scoped loops to avoid similar.

Codechange: Call Widget::SetDirty/SetLowered directly. (#11417)

In these instances we already have the widget to hand, so don't need to look it up by index again.

Codechange: Assign/StoreSizePosition x/y can be negative. (#11416)

AssignSizePosition is used with negative values when an NWidgetMatrix is
scrolled, but they were passed as unsigned and then stored as signed.

Widget pos_x/pos_y were already made signed.

Update: Translations from eints
english (au): 1 change by krysclarke
chinese (simplified): 5 changes by WenSimEHRP
korean: 2 changes by telk5093
russian: 1 change by Ln-Wolf
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by pasantoro
polish: 1 change by pAter-exe

Fix 233aac5: Set newline default comment for new groups. (#11411)

The newline space between ini groups is actually recorded as a comment of the group. This got inadvertantly dropped in #11364.