Codechange: Replace AllocatedStringParameters with ArrayStringParameters (#11452)

All uses of AllocatedStringParameters are with a compile-time fixed
constant.
Use of a dynamically allocated buffer on the heap is unnecessary and
increases overhead, particularly due to frequent use as a temporary.

Update: Translations from eints
german: 3 changes by SecretIdetity
romanian: 6 changes by bnegrut

Update: Translations from eints
hungarian: 54 changes by titanicbobo

Add: WidgetDimensions for 'sparse' widget windows.

These are for windows that have space between widgets instead of being clumped together.

Update: Translations from eints
chinese (simplified): 1 change by WenSimEHRP
danish: 1 change by bscargo
hindi: 111 changes by NisheshTyagi

Codechange: Add base() method to StrongType to allow access to the base type without casting. (#11445)

This removes the ability to explicitly cast to the base type, but the requirement
to use .base() means the conversion is still explicit.

Update: Translations from eints
korean: 14 changes by telk5093
polish: 1 change by pAter-exe

Change: Add horizontal scrollbar to Industry Directory window.

This list could be very wide depending on industries and language.

Codechange: Don't filter industry list by cargo type every 3-sec refresh.

The 3-sec refresh is to update the list sorting. The filter only needs to
be applied once rebuilding the list.

Codechange: Skip invisible (zero-size) widgets in PIP Containers.

This gets rid of doubled-up spacing where an invisible child widget would be.

Codechange: Add ability to allocate PIP-space dynamically by ratio.

This can be used to space out, centre, start-align, or end-align widgets without additional spacers.

Fix #11437: Flipped shorter rail vehicles disappear in windows. (#11446)

Mixed signed/unsigned strikes again, causing an incorrect sprite offset for shortened vehicles.

Codechange: Don't be lenient with invalid NWidgetPart lists.

Some NWidgetPart combinations were ignored but it was not clear that they do nothing. Instead, assert if NWidgetPart is incorrectly applied.

Add: Mock sprite cache intialization.

This fills up the sprite cache with SPR_OPENTTD_BASE + OPENTTD_SPRITE_COUNT zero-size sprites, to
allow GetSpriteSize() calls to continue from unit-tests.

Add: Expose minimal parts of SpriteCache internals.

These parts are needed to be able to mock the SpriteCache for unit-tests.

Update: Translations from eints
korean: 1 change by telk5093
finnish: 1 change by hpiirai
portuguese (brazilian): 1 change by pasantoro

Fix: Using MIN_YEAR for a date is probably wrong, Use MIN_DATE instead. (#11444)

Even with strong types ...

Update: Translations from eints
english (us): 3 changes by 2TallTyler
french: 2 changes by Lishouuu

Codechange: Replicate cursor screen backup to chat message display, removing explicit memory management.

Incidentally, this makes Blitter::GetBytesPerPixel unneeed.

Fix #9545: Crash when all cargo types are disabled. (#11432)

This is not a very useful state, but it's nice to not crash.

Some parts of the game don't (yet) check for cargo types being redefined, that is out-of-scope here.

Fix cda6f24f: don't ignore binary-dir if it happens to be working-dir (#11431)

Some of our code ignores the SP_WORKING_DIR for some actions, which
means that if, for example, your SP_BINARY_DIR is the same as your
SP_WORKING_DIR, neither is scanned.

Instead, only add SP_WORKING_DIR if it is unique.

Codechange: Avoid pointers and lengthof in ExpensesList. (#11427)

Use std::initializer_list which allows iteration.

Cleanup: Remove some unused functions. (#11429)

These were picked up with cppcheck.

Update: Translations from eints
english (au): 1 change by krysclarke
russian: 1 change by Ln-Wolf
dutch: 3 changes by Afoklala
portuguese: 1 change by azulcosta

Codechange: Add unit-test to check if nested widget parts of properly closed.

Properly closed means exactly one EndContainer for every Container widget.

Add: WindowDesc unit test to validate ini-key value.

ini-key must be present if WWT_DEFSIZEBOX or WWT_STICKYBOX is present.
This was previously enforced by a workflow, however that parsed the source
code with regex which turned out to be error-prone.

Codechange: Add __FILE__/__LINE__ of WindowDesc to WindowDesc.

This is to allow unit-tests to produce more useful output.

Fix: AI config window should not have an ini_key. (#11423)

This was missed by the workflow script that enforces this constraint.

Update: Translations from eints
finnish: 2 changes by hpiirai
danish: 1 change by bscargo

Codechange: Move includes to correct place.

Some other source file inadvertently included things via smallmap_gui.h

Revert 6b68956: Move declaration of SmallMapWindow out of header file.

This split needlessly complicates `SmallMapWindow` for the sake of one method (no longer) used by `LinkGraphOverlay`.

Fix #11413: Incorrect sorting by industry production.

Error caused by single character mistake. However this algorithm was inefficent if a filter was specified, and clearly the flow was error-prone.

Now using separately-scoped loops to avoid similar.

Codechange: Call Widget::SetDirty/SetLowered directly. (#11417)

In these instances we already have the widget to hand, so don't need to look it up by index again.

Codechange: Assign/StoreSizePosition x/y can be negative. (#11416)

AssignSizePosition is used with negative values when an NWidgetMatrix is
scrolled, but they were passed as unsigned and then stored as signed.

Widget pos_x/pos_y were already made signed.

Update: Translations from eints
english (au): 1 change by krysclarke
chinese (simplified): 5 changes by WenSimEHRP
korean: 2 changes by telk5093
russian: 1 change by Ln-Wolf
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by pasantoro
polish: 1 change by pAter-exe

Fix 233aac5: Set newline default comment for new groups. (#11411)

The newline space between ini groups is actually recorded as a comment of the group. This got inadvertantly dropped in #11364.

Fix: Incorrect padding for smallmap legend 'icon'.

The size of this icon is based off FONT_HEIGHT_SMALL - 1, so it makes sense to use a scaled 1 here.

Update: Translations from eints
english (au): 1 change by krysclarke
dutch: 1 change by TrueBrain
portuguese: 1 change by azulcosta
polish: 4 changes by pAter-exe

Update: Translations from eints
indonesian: 1 change by liimee
russian: 2 changes by Ln-Wolf
finnish: 1 change by hpiirai
danish: 1 change by bscargo
french: 1 change by ottdfevr
portuguese (brazilian): 1 change by pasantoro

Add: Debug tool to draw widget outlines. (#11401)

This is considered a developer tool and is controlled from the help menu (or default hotkey Ctrl-O).

This draws a white dashed outline around widgets. NWidgetSpacer and (unused) WWT_EMPTY widgets are also filled with check pattern to highlight them, as they usually indicate a design issue.

Fix d42a78f: Some raw drop down list strings may need token processing. (#11400)

Storing the raw string without processing though GetString() caused token
processing to be skipped.

Update: Translations from eints
dutch: 3 changes by Afoklala
french: 1 change by ottdfevr

Update: Translations from eints
korean: 3 changes by telk5093
slovak: 1 change by legitalk
polish: 4 changes by pAter-exe

Fix: [CI] Installed (and cached) vcpkg packages are never upgraded in release-linux workflow (#11396)

Other workflows use a per image cache because images provide a fixed vcpkg clone.

Update: Translations from eints
english (us): 3 changes by 2TallTyler
danish: 3 changes by bscargo
polish: 1 change by pAter-exe

Update: Translations from eints
czech: 18 changes by vladoschreiner
german: 27 changes by Wuzzy2

Update: Translations from eints
english (au): 3 changes by krysclarke
russian: 3 changes by Ln-Wolf
finnish: 3 changes by hpiirai
turkish: 4 changes by BeratSJ
french: 3 changes by ottdfevr
portuguese: 3 changes by azulcosta
portuguese (brazilian): 3 changes by pasantoro

Codechange: Remove unused parameter for Height()

DropDownListItem::Height does not need to take an argument so remove it

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>

Codechange: Use unified NWidgetContainer methods instead of duplicating.

Most NWidgetContainer derivatives implemented Draw() and GetWidgetFromPos()
the same way. Move this these to NWidgetContainer itself to avoid repeating.

Codechange: Hide toolbar buttons by setting width to zero.

Zero-width is how widgets are hidden elsewhere.
This removes the need for an extra array to lookup if a button is hidden.