Codechange: Rearrange AI/GS debug window following invalidate/set state/draw pattern. (#11483)

The AI/GS window updated its state as it was drawn, and would redraw again if some state had changed.

Instead, update state either during OnInvalidateData or before any drawing commences.

Add: Website button to Game Options window for basesets.

This links to the optional "url" item in the baseset's [metadata] section.

Change: Hide unused cargos from vehicle cargo filter. (#11533)

The list of used cargo types is updated when the list is invalidated.

Remove: officially mark Vista as no longer supported (#11531)

It is very likely Vista hasn't been working for years, but the
amount of users that use an OS that has been EoL for over 11 years
is very small, so reports happen rarely.

Feature: Place cargo icon on cargo filter dropdowns.

Reveal the pixel art.

Codechange: Add DropDownIcon constructor to override dimension.

This avoids the need to construct a DropDownIcon and set the dimension after.

Change: Use CRTP-mixins to compose dropdown list items.

This allows list items to built from component parts as required, and additional
functionality is added:

* Icons and text can be positioned at the start or end of the space (templated.)
* Font size of text can be changed (templated.)
* Palette of sprites can be set (runtime.)

Codechange: Dimension must have both width and height.

Default parameters allowed Dimension to be constructed with only a width.

Instead use separate empty and width/height constructors to ensure that either none or both are provided.

Change: Add extra padding to climate buttons to match pre-#11464. (#11525)

Padding used to be included in the SetMinimalSize() part which was removed, but also made it require specific sprite sizes.

This now adds padding on the already determined size, removing the need for hardcoding pixel dimensions and allowing the sprites to be any size.

Codechange: Make a generic DrawRectOutline function from DrawOutline. (#11524)

This allows drawing an outline from Rect, not just constrained to a Widget's Rect. And reduces duplication a little.

Remove: ZOOM_LVL_COUNT

This is the only enumeration with a COUNT and END. The logic of the COUNT
implied that BEGIN could be non-zero, but all but two uses of zoom level
assume that BEGIN is zero, making the separate count only confusing.

Feature: Randomize direction of rail vehicle on build based on probability callback. (#11489)

This allows NewGRF authors to indicate that the game should randomly flip rail vehicles on build, without needing to use random bits nor duplicate sprites to handle it themselves.

To use this functionality, test for callback 162 (CBID_VEHICLE_BUILD_PROBABILITY) and var10 = 0 (values other than 0 are reserved for future use), and return a value between 0 and 100 inclusive.

The return value is a percentage chance of reversing the vehicle. A value of 0 will always build a forward facing vehicle, and 100 will always build a reverse facing vehicle.

Fix ab1a4c6c: Crash if the "No Music" set is loaded because there is no current set_index. (#11511)

Add a helper function to get the current set_index which which checks it is in range.

Codechange: Use range-for to simplify getting first non-zero value.

This reduces indexed array access.

Codechange: Be consistent with how we name common parameters

TileIndex is always tile and Town is always *t. Don't use t and *town.

Codechange: Rename TryClearTile() for clarity

The function does not execute the clearing action.

Codechange: Use consistent name for bay road stops

As of #10494, this is how we describe original dead-end road stops.

Update: Translations from eints
english (us): 1 change by 2TallTyler

Fix ab1a4c6c: Changing baseset/playlist while shuffle is on does not change song. (#11510)

The change-playlist function relied on toggling shuffle to restart playing which is no longer the case, so always handle it when changing playlist instead.

Fix #10926: New free wagons no longer split by type. (#11507)

NormalizeTrainVehInDepot() should only be called if an engine was built, not for wagons.

Codechange: Template input buffer type in audio mixer. (#11505)

This reduces code duplication.

Codechange: Use std::array for industry tile cargo acceptance. (#11498)

This avoids use of memcpy/memset to copy or fill.

Change: Don't restart playback when toggling playlist shuffle.

Instead update the selected playlist entry for the current song.

Change: Try stopping extmidi player with SIGINT first. (#11404)

This may give the player a chance to issue MIDI note-off commands.

The kill/waitpid cycle is also less aggressive, waiting 50ms each time.

Fix #11500: Rename Textfile GUI's LinkType to HyperlinkType. (#11502)

This disambiguates it with LinkType in league tables.

Fix: Add shading to river slopes

Adds a 32bpp shading to the river rapids/slopes to make them more visible. Requires a bump of original graphics grfs to use container version 2. Fixes #9031

Change: Set height of larger heightmap/scenario worldgen buttons by text height. (#11496)

This allows the button height to scale properly by font size.

Change: When building NewGRFs, use grfid (from grfcodec) to calculate NewGRF MD5 hash. (#11492)

This allows for v2 container NewGRFs to be created. Hashes are needed for building the baseset metadata, so the .hash files are stored the source tree so they can be built if grfcodec and grfid are not present.

The hash of openttd.grf is not actually needed, but it is simpler to leave it in than handle only orig_extra.grf.

Codechange: List toolbar menu items and dividers explicitly.

This makes it clearer what items will be shown in the list, allows for non-consecutive
string IDs, and means unused enum values are not necessary.

Fix 7cfcf65: Check if last-remembered build vehicle cargo filter is valid. (#11486)

This can be invalid when switching between games with different cargoes loaded.

Fix: Restore original cargo legend 'blob' dimensions. (#11480)

An off-by-one in a previous life made the 'blob' too narrow.

Codechange: Remove FONT_HEIGHT_... macros. (#11481)

These make it look like we're dealing with a constant, but actually each is a call to `GetCharacterHeight(...)`.

Update: Translations from eints
indonesian: 67 changes by ekaknl22

Fix 96d98d08: Crash in text layouter due to trying to find height of string with zero-width.

96d98d08 removed the hardcoded minimum width in favour of all-calculated widths, however this does not work when determining multiline text sizes.

Codechange: Add method to guess the width/height required for a multiline string.

This is necessary for widget layouts where a minimum width is not yet known during UpdateWidgetSize().

Codechange: Assert that max width passed to GetStringHeight is non-zero.

Max width of zero will cause text layouters to crash, potentially after exhausting memory first.

Fix: Trivial autoreplace of mixed cargo articulated engines (#11253)

Do not fail autoreplace/autorenew of mixed cargo articulated engines
due to an inability to refit to mixed cargoes, when no refit is
required because the target engine already has a suitable set of cargoes.
Notably, this allows autorenew (autoreplace to same engine type)
to succeed.

Codechange: Simplify setting minimum width for game options dropdown lists. (#11474)

Height isn't necessary as drop down controls already have sufficient height, so we can use GetDropDownListDimension() to get the width.

Codechange: Remove now-unnecessary containers in picker layouts. (#11473)

These are no longer necessary as the issue they work around was resolved by #11471

Fix: Extra space allocated to container-within-container may not get allocated to children. (#11471)

Always derive additional length from contained widgets instead of from the container, as the container's minimal length may have been adjusted by an NC_EQUALSIZE parent container.

Update: Translations from eints
dutch: 1 change by Afoklala

Fix: extmidi did not move on to next song after playing ends. (#11469)

`song` is no longer a C-style string so cannot be cleared by writing a NUL char.
Use `.clear()` to properly clear a std::string.

Update: Translations from eints
french: 1 change by Lishouuu

Codechange: Move RectPadding::zero definition to header. (#11461)

This potentially allows better inlining/optimization.

Update: Translations from eints
tamil: 3 changes by Jeyanthinath

Codechange: Simplify cargo filter lists, building only when required.

Some cargo filter lists were built in advance, and used as lookups to test which cargo type to filter.

Instead, use the Cargo ID directly as the filter parameter, and build the lists only when the drop down list is used.

Update: Translations from eints
danish: 1 change by bscargo
polish: 1 change by pAter-exe

Codechange: Simplify autoreplace rail/road types by using separate widget. (#11457)

This avoids needing to determine which type of list to deal with by additionally checking the window number for VEH_TRAIN/VEH_ROAD.

Update: Translations from eints
vietnamese: 7 changes by KhoiCanDev
korean: 1 change by telk5093
catalan: 7 changes by J0anJosep

Update: Translations from eints
english (au): 1 change by krysclarke
italian: 7 changes by Rivarossi
russian: 1 change by Ln-Wolf
finnish: 1 change by hpiirai
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by pasantoro

Change: Move baseset missing/corrupted files label to list item. (#11455)

This allows any baseset error to be displayed in the drop down list so it is more easily visible, and avoids wasted space in the layout.